From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48490)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1a7K5J-0003Je-CS
	for qemu-devel@nongnu.org; Fri, 11 Dec 2015 04:33:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1a7K5F-0004JL-CI
	for qemu-devel@nongnu.org; Fri, 11 Dec 2015 04:33:53 -0500
Received: from mx2.parallels.com ([199.115.105.18]:39978)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1a7K5F-0004JH-72
	for qemu-devel@nongnu.org; Fri, 11 Dec 2015 04:33:49 -0500
References: <1449240275-26196-1-git-send-email-den@openvz.org>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <566A9873.7050400@openvz.org>
Date: Fri, 11 Dec 2015 12:33:39 +0300
MIME-Version: 1.0
In-Reply-To: <1449240275-26196-1-git-send-email-den@openvz.org>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 for 2.6 0/5] QMP wrappers for VM
	snapshot operations
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Cc: Amit Shah <amit.shah@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, quintela@redhat.com

On 12/04/2015 05:44 PM, Denis V. Lunev wrote:
> EFI based VM with pflash storage for NVRAM could not be snapshoted as
> libvirt configures storage as 'raw' and writable. OK, this is a libvirt
> problem.
>
> Another problem is that libvirt can not detect this failure at all
> as it uses HMP for this operation. This create snapshot/delete snapshot
> sequence passes silently.
>
> The patchset adds QMP wrappers for the purpose.
>
> Signed-off-by: "Denis V. Lunev" <den@openvz.org>
> CC: Juan Quintela <quintela@redhat.com>
> CC: Amit Shah <amit.shah@redhat.com>
> CC: Markus Armbruster <armbru@redhat.com>
> CC: Eric Blake <eblake@redhat.com>
>
> Changes from v1:
> - cosmetic fixes suggested by Markus. I pray I have added all of them :)
> - patch 5 is rewritten completely. Original one was deadbeaf
>
> Denis V. Lunev (5):
>    migration: split hmp_savevm to do_savevm and hmp_savevm wrapper
>    qmp: create qmp_savevm command
>    qmp: create qmp_delvm command
>    migration: improve error reporting for hmp_loadvm
>    qmp: create QMP implementation of loadvm command
>
>   include/sysemu/sysemu.h |   2 +-
>   migration/savevm.c      | 100 +++++++++++++++++++++++++++++++-----------------
>   monitor.c               |   7 +++-
>   qapi-schema.json        |  39 +++++++++++++++++++
>   qmp-commands.hx         |  71 ++++++++++++++++++++++++++++++++++
>   vl.c                    |   5 ++-
>   6 files changed, 185 insertions(+), 39 deletions(-)
>
ping