From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7O10-0005PZ-1X for qemu-devel@nongnu.org; Fri, 11 Dec 2015 08:45:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7O0u-0001rq-P4 for qemu-devel@nongnu.org; Fri, 11 Dec 2015 08:45:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7O0u-0001rm-JV for qemu-devel@nongnu.org; Fri, 11 Dec 2015 08:45:36 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 21F44A3262 for ; Fri, 11 Dec 2015 13:45:36 +0000 (UTC) References: <1449791621-16185-1-git-send-email-eblake@redhat.com> <1449791621-16185-9-git-send-email-eblake@redhat.com> <566AAF3A.8090902@redhat.com> <566AD2E0.90006@redhat.com> From: Paolo Bonzini Message-ID: <566AD37C.60103@redhat.com> Date: Fri, 11 Dec 2015 14:45:32 +0100 MIME-Version: 1.0 In-Reply-To: <566AD2E0.90006@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 08/11] qjson: Simplify by using json-output-visitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 11/12/2015 14:42, Eric Blake wrote: >>> compiles and is pretty much a 1:1 translation from the qjson.c >>> API to the visitor API (using this patch as a guide). Feel >>> free to include it and remove qjson.c. Alternatively, you can >>> leave out this patch and I'll test and submit the transition. > Should I squash the two together, or keep my current patch and > drop qjson.c as a separate patch? As you prefer. > Also, while reading this, I noticed that qjson.h has signatures > that match JSON ('name' comes before 'value', when generating a > "name":value pair), while visitor.h has signatures that are > backwards ('obj' comes before 'name', even though the output will > be "name":value-of-obj). I'm seriously debating about a tree-wide > coccinelle patch to reverse the order or arguments of all the > visit_type_* functions. That would be doable, there aren't many users outside generated code. Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWatN5AAoJEL/70l94x66D8PQIAKEzIEUqjfhDMLhov4NwxGs3 LvyW+/w5AyDEZOJMayBuc3y7fSTbLp/eMQPsfBOIvBCMr/aEE4Tij0CzW3JE4FnH IFCW94F8Q7vq8jTYKFU6222Nk7vUGOLG9y3jQSnLX4RzpRizhWjk73DtkED7YVu3 5J0Ef3+ZEobCZA9zOwQT7+pqc9ah/M6tGsZodvML2FopCk/SsTBauPjoSeP0knHE 1MJsu/KVjn1508yn1SY9d0HJKQx2dM3nzQRtp0xbWx7x8o7u826axpVQieq7YBpb PaRW/vqiXvdnRkrCRHZAL6PJ4GLyquX42E7HjqCQjibA06fbtqmLoYQA2A/2Pyg= =EJIn -----END PGP SIGNATURE-----