From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49451)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1a7O86-0004A1-3J
	for qemu-devel@nongnu.org; Fri, 11 Dec 2015 08:53:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1a7O81-0003uC-3D
	for qemu-devel@nongnu.org; Fri, 11 Dec 2015 08:53:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:34838)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1a7O80-0003tx-UK
	for qemu-devel@nongnu.org; Fri, 11 Dec 2015 08:52:57 -0500
References: <20151211001505.GV2905@var.home>
	<1449792930-27293-1-git-send-email-samuel.thibault@ens-lyon.org>
	<1449792930-27293-2-git-send-email-samuel.thibault@ens-lyon.org>
	<566AD1E4.1050403@redhat.com> <566AD30E.2060002@redhat.com>
	<20151211134706.GC2927@var.bordeaux.inria.fr>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <566AD533.9060008@redhat.com>
Date: Fri, 11 Dec 2015 14:52:51 +0100
MIME-Version: 1.0
In-Reply-To: <20151211134706.GC2927@var.bordeaux.inria.fr>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing
 code before adding IPv6 stuff
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@gnu.org>, Jan Kiszka <jan.kiszka@siemens.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, Jason Wang <jasowang@redhat.com>, Dave Gilbert <dgilbert@redhat.com>, Vasiliy Tolstov <v.tolstov@selfip.ru>, qemu-devel@nongnu.org, Gonglei <arei.gonglei@huawei.com>, Huangpeng <peter.huangpeng@huawei.com>, Guillaume Subiron <maethor@subiron.org>

On 11/12/15 14:47, Samuel Thibault wrote:
> Thomas Huth, on Fri 11 Dec 2015 14:43:42 +0100, wrote:
>> Anyway, it's IMHO a somewhat strange way to structure a patch ... maybe
>> it would be nicer to do it in one go instead (after splitting off the
>> arp_requested renaming)?
> 
> Please discuss about it with the people who asked for it.  I won't
> revamp patches until what people prefer is settled.

It's maybe best if Jan Kiszka could comment on such question since he's
the slirp subsystem maintainer and finally has to decide whether to take
the patches or not.

 Thomas