From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7PXH-00048G-5b for qemu-devel@nongnu.org; Fri, 11 Dec 2015 10:23:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7PXD-0002Bb-4d for qemu-devel@nongnu.org; Fri, 11 Dec 2015 10:23:07 -0500 References: <1449792685-17000-1-git-send-email-david@gibson.dropbear.id.au> <1449792685-17000-12-git-send-email-david@gibson.dropbear.id.au> From: Eric Blake Message-ID: <566AEA53.9090009@redhat.com> Date: Fri, 11 Dec 2015 08:22:59 -0700 MIME-Version: 1.0 In-Reply-To: <1449792685-17000-12-git-send-email-david@gibson.dropbear.id.au> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="no2SMug4xnOfuqgmCCC5TVXL4H45tKK9R" Subject: Re: [Qemu-devel] [PATCH 11/11] pseries: Clean up error reporting in htab migration functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , armbru@redhat.com, aik@ozlabs.ru, mdroth@linux.vnet.ibm.com Cc: lvivier@redhat.com, thuth@redhat.com, qemu-ppc@nongnu.org, agraf@suse.de, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --no2SMug4xnOfuqgmCCC5TVXL4H45tKK9R Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/10/2015 05:11 PM, David Gibson wrote: > The functions for migrating the hash page table on pseries machine type= > (htab_save_setup() and htab_load()) can report some errors with an > explicit fprintf() before returning an appropriate eror code. Change t= hese > to use error_report() instead. >=20 > Signed-off-by: David Gibson > --- > hw/ppc/spapr.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) >=20 > =20 > @@ -1577,9 +1578,9 @@ static int htab_load(QEMUFile *f, void *opaque, i= nt version_id) > if ((index + n_valid + n_invalid) > > (HTAB_SIZE(spapr) / HASH_PTE_SIZE_64)) { > /* Bad index in stream */ > - fprintf(stderr, "htab_load() bad index %d (%hd+%hd entries= ) " > - "in htab stream (htab_shift=3D%d)\n", index, n_val= id, n_invalid, > - spapr->htab_shift); > + error_report( > + "htab_load() bad index %d (%hd+%hd entries) in htab st= ream (htab_shift=3D%d)\n", > + index, n_valid, n_invalid, spapr->htab_shift); No trailing newline to error_report(). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --no2SMug4xnOfuqgmCCC5TVXL4H45tKK9R Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWaupTAAoJEKeha0olJ0NqzNMH/i795WvDnldfbNdmUg5uunVg sLGXMENK6fpeCXkNgMt/0YPDkUoJFhi/T5q5mzYuKcSO1HGO5disWETiHjpvEfFd SmrCYFLLVshkm1PlkR99jJ9koHQiaAClDBBbFVKqLKwNJCIkqi0nnQclwHxaOwS1 6of+j6b595ikoPBML7oAY409MFc3P6mvgYjJowSWW5w823yNa49LTff1UJP4Cd/Q jWfFlqLwviJqPVqJ1C+c0W4E5zc2le48NyXaIUsSxZ+UhPP6kgmgwjqfKxdpwUgr dZqqL6sN/zbCjBPRDzspIbwh2MedwUActxTcDCpenqrQKcmPHxvarpecD9LvGrk= =WSAD -----END PGP SIGNATURE----- --no2SMug4xnOfuqgmCCC5TVXL4H45tKK9R--