From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7PeT-0002jK-4t for qemu-devel@nongnu.org; Fri, 11 Dec 2015 10:30:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7PeP-0003ws-25 for qemu-devel@nongnu.org; Fri, 11 Dec 2015 10:30:33 -0500 References: <1449847385-13986-1-git-send-email-mreitz@redhat.com> <1449847385-13986-2-git-send-email-mreitz@redhat.com> From: Eric Blake Message-ID: <566AEC0B.1070009@redhat.com> Date: Fri, 11 Dec 2015 08:30:19 -0700 MIME-Version: 1.0 In-Reply-To: <1449847385-13986-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NevwH7PwgmEEOGfcfhkCK6CxhTxKeWjCt" Subject: Re: [Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org, Peter Maydell Cc: Kevin Wolf , Markus Armbruster , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NevwH7PwgmEEOGfcfhkCK6CxhTxKeWjCt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/11/2015 08:23 AM, Max Reitz wrote: > While in the long term we want throttling to be its own block filter > BDS, in the short term we want it to be part of the BB instead of a BDS= ; > even in the long term we may want legacy throttling to be automatically= > tied to the BB. >=20 > blockdev-insert-medium and blockdev-remove-medium do not retain > throttling information in the BB (deliberately so). Therefore, using > them means tying this information to a BDS, which would break the model= > described above. (The same applies to other flags such as > detect_zeroes.) We probably want to move this information to the BB or > its own filter BDS before blockdev-{insert,remove}-medium can be > considered completely stable. >=20 > Therefore, mark these functions experimental for the time being. >=20 > Suggested-by: Markus Armbruster > Signed-off-by: Max Reitz > Acked-by: Markus Armbruster > Acked-by: Kevin Wolf > --- Reviewed-by: Eric Blake > +++ b/qmp-commands.hx > @@ -4203,13 +4203,13 @@ Example: > EQMP > =20 > { > - .name =3D "blockdev-remove-medium", > + .name =3D "x-blockdev-remove-medium", > .args_type =3D "device:s", > - .mhandler.cmd_new =3D qmp_marshal_blockdev_remove_medium, > + .mhandler.cmd_new =3D qmp_marshal_x_blockdev_remove_medium, > }, > =20 > SQMP > -blockdev-remove-medium > +x-blockdev-remove-medium > ---------------------- Formatting nit, but not worth holding this up (as it is really our last chance to get it in 2.5 before baking in something we'd be stuck with). > =20 > SQMP > -blockdev-insert-medium > +x-blockdev-insert-medium > ---------------------- Ditto. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --NevwH7PwgmEEOGfcfhkCK6CxhTxKeWjCt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWauwLAAoJEKeha0olJ0NqqR4H/jDnSv0q3GUSKBUstdvSI1aS 7UyEBoI/eoFKHn8NPaYdvOeKt7cVzrVaRyK+f7M/aKh7siEx5ou/N8H8lAom8dti JH/j1EVI11l0Iy/b8C7lV+jTQtZnqdbIbOG4YKyGXqijo7oETlUI6a2VT4p7KVfl hZLyxptW0/6eH3AIn4ch9OMRkv/Z+a5SrpdrxHcdYEDTMhjgn3KX8UO+pkZBogNy lqgKibqMIddZtciimY34vcMcIXnSZb5W2QznmFvfO3mPnN2wg/BsjHZKF0kJYgGx PKiSt+vyxUji1qNI3Qxul/j+r4vPMcrinl6h8BJpYLXNUXHtdG5HSF4yB4g2eZo= =tEeG -----END PGP SIGNATURE----- --NevwH7PwgmEEOGfcfhkCK6CxhTxKeWjCt--