From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] tcg/tcg.c ifndef USE_LIVENESS_ANALYSIS code won't compile
Date: Fri, 11 Dec 2015 09:25:06 -0800 [thread overview]
Message-ID: <566B06F2.1010301@twiddle.net> (raw)
In-Reply-To: <CAFEAcA8w-6gqx+wo+tmm-00B7WGpitkyCiumD5q91ntpj8vtLw@mail.gmail.com>
On 12/11/2015 05:41 AM, Peter Maydell wrote:
> Hi; I noticed while grepping through code that the version of
> tcg_liveness_analysis() in tcg/tcg.c for #ifndef USE_LIVENESS_ANALYSIS
> won't compile because it's still referring to the no-longer-existent
> TCGContext::gen_opc_buf.
Oops.
> Richard, I think this was probably broken as part of your changes to
> use a linked list of ops instead. Should we update the dummy function,
> or just delete it on the grounds nobody noticed it was broken? :-)
>
> (There are also 3 now-stale comments in the tree that refer to
> gen_opc_buf still.)
I guess we should keep it, since it's so easy to do so.
Patch to follow.
r~
prev parent reply other threads:[~2015-12-11 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 13:41 [Qemu-devel] tcg/tcg.c ifndef USE_LIVENESS_ANALYSIS code won't compile Peter Maydell
2015-12-11 17:25 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566B06F2.1010301@twiddle.net \
--to=rth@twiddle.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).