From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49689)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1a7RRS-0002by-Pk
	for qemu-devel@nongnu.org; Fri, 11 Dec 2015 12:25:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1a7RRP-0003GC-2p
	for qemu-devel@nongnu.org; Fri, 11 Dec 2015 12:25:14 -0500
Received: from mail-qg0-x232.google.com ([2607:f8b0:400d:c04::232]:34184)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1a7RRO-0003G7-Vw
	for qemu-devel@nongnu.org; Fri, 11 Dec 2015 12:25:11 -0500
Received: by qgz52 with SMTP id 52so14112028qgz.1
	for <qemu-devel@nongnu.org>; Fri, 11 Dec 2015 09:25:10 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
References: <CAFEAcA8w-6gqx+wo+tmm-00B7WGpitkyCiumD5q91ntpj8vtLw@mail.gmail.com>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <566B06F2.1010301@twiddle.net>
Date: Fri, 11 Dec 2015 09:25:06 -0800
MIME-Version: 1.0
In-Reply-To: <CAFEAcA8w-6gqx+wo+tmm-00B7WGpitkyCiumD5q91ntpj8vtLw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] tcg/tcg.c ifndef USE_LIVENESS_ANALYSIS code won't
	compile
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>

On 12/11/2015 05:41 AM, Peter Maydell wrote:
> Hi; I noticed while grepping through code that the version of
> tcg_liveness_analysis() in tcg/tcg.c for #ifndef USE_LIVENESS_ANALYSIS
> won't compile because it's still referring to the no-longer-existent
> TCGContext::gen_opc_buf.

Oops.

> Richard, I think this was probably broken as part of your changes to
> use a linked list of ops instead. Should we update the dummy function,
> or just delete it on the grounds nobody noticed it was broken? :-)
>
> (There are also 3 now-stale comments in the tree that refer to
> gen_opc_buf still.)

I guess we should keep it, since it's so easy to do so.
Patch to follow.


r~