* [Qemu-devel] tcg/tcg.c ifndef USE_LIVENESS_ANALYSIS code won't compile
@ 2015-12-11 13:41 Peter Maydell
2015-12-11 17:25 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2015-12-11 13:41 UTC (permalink / raw)
To: QEMU Developers; +Cc: Richard Henderson
Hi; I noticed while grepping through code that the version of
tcg_liveness_analysis() in tcg/tcg.c for #ifndef USE_LIVENESS_ANALYSIS
won't compile because it's still referring to the no-longer-existent
TCGContext::gen_opc_buf.
Richard, I think this was probably broken as part of your changes to
use a linked list of ops instead. Should we update the dummy function,
or just delete it on the grounds nobody noticed it was broken? :-)
(There are also 3 now-stale comments in the tree that refer to
gen_opc_buf still.)
thanks
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] tcg/tcg.c ifndef USE_LIVENESS_ANALYSIS code won't compile
2015-12-11 13:41 [Qemu-devel] tcg/tcg.c ifndef USE_LIVENESS_ANALYSIS code won't compile Peter Maydell
@ 2015-12-11 17:25 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2015-12-11 17:25 UTC (permalink / raw)
To: Peter Maydell, QEMU Developers
On 12/11/2015 05:41 AM, Peter Maydell wrote:
> Hi; I noticed while grepping through code that the version of
> tcg_liveness_analysis() in tcg/tcg.c for #ifndef USE_LIVENESS_ANALYSIS
> won't compile because it's still referring to the no-longer-existent
> TCGContext::gen_opc_buf.
Oops.
> Richard, I think this was probably broken as part of your changes to
> use a linked list of ops instead. Should we update the dummy function,
> or just delete it on the grounds nobody noticed it was broken? :-)
>
> (There are also 3 now-stale comments in the tree that refer to
> gen_opc_buf still.)
I guess we should keep it, since it's so easy to do so.
Patch to follow.
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-11 17:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-11 13:41 [Qemu-devel] tcg/tcg.c ifndef USE_LIVENESS_ANALYSIS code won't compile Peter Maydell
2015-12-11 17:25 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).