From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7SUH-000465-WB for qemu-devel@nongnu.org; Fri, 11 Dec 2015 13:32:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7SUE-00069v-55 for qemu-devel@nongnu.org; Fri, 11 Dec 2015 13:32:13 -0500 Received: from e17.ny.us.ibm.com ([129.33.205.207]:33572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7SUE-00069q-03 for qemu-devel@nongnu.org; Fri, 11 Dec 2015 13:32:10 -0500 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 11 Dec 2015 13:32:09 -0500 Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 2106B6E803F for ; Fri, 11 Dec 2015 13:20:16 -0500 (EST) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tBBIW6ZB28967140 for ; Fri, 11 Dec 2015 18:32:06 GMT Received: from d01av05.pok.ibm.com (localhost [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tBBITAr2032499 for ; Fri, 11 Dec 2015 13:29:11 -0500 References: <1449845523-22177-1-git-send-email-jjherne@linux.vnet.ibm.com> From: "Jason J. Herne" Message-ID: <566B169F.8020305@linux.vnet.ibm.com> Date: Fri, 11 Dec 2015 13:31:59 -0500 MIME-Version: 1.0 In-Reply-To: <1449845523-22177-1-git-send-email-jjherne@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] checkpatch: Detect newlines in error_report and other error functions Reply-To: jjherne@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: blauwirbel@gmail.com, cornelia.huck@de.ibm.com, qemu-devel@nongnu.org On 12/11/2015 09:52 AM, Jason J. Herne wrote: > We don't want newlines embedded in error messages. This seems to be a common > problem with new code so let's try to catch it with checkpatch. > > This does not catch the newline when it is in a multiline statement. This is > quite a bit more difficult and can be handled as follow on work. > > Signed-off-by: Jason J. Herne > ... Ignore this one, I found some time to write up a better version that handles the most common multi-line cases. See v2. Sorry for the spam :) -- -- Jason J. Herne (jjherne@linux.vnet.ibm.com)