From: Laurent Vivier <laurent@vivier.eu>
To: Michael Karcher <Michael.Karcher@fu-berlin.de>,
Michael Karcher <karcher@physik.fu-berlin.de>,
Riku Voipio <riku.voipio@iki.fi>,
qemu-devel@nongnu.org
Cc: glaubitz@physik.fu-berlin.de
Subject: Re: [Qemu-devel] [PATCH 1/1] Fix do_rt_sigreturn on m68k linux userspace emulation
Date: Sat, 12 Dec 2015 11:35:05 +0100 [thread overview]
Message-ID: <566BF859.1060704@vivier.eu> (raw)
In-Reply-To: <566BEEFD.5010809@fu-berlin.de>
Le 12/12/2015 10:55, Michael Karcher a écrit :
> On 09.12.2015 23:03, Laurent Vivier wrote:
>>
>> Le 09/12/2015 21:54, Michael Karcher a écrit :
>>> do_rt_sigreturn forgets to initialize the signal mask variable before
>>> trying to use it to restore the mask, so the signal mask is undefined
>>> after do_rt_sigreturn. This bug has been in all the time since
>>> 7181155d when do_rt_sigreturn was implemented for m68k.
>>>
[...]
> BTW: documentation of the stack frame / signature for non-SA_SIGINFO
> signal handlers seems to be quite lacking. There is a remark in the
> sigaction manpage, but that one obviously only applies to i386...
The best documentation is the kernel source: if you have a look at it
you will see that these functions (setup_frame(), do_sigreturn(), ...)
are just QEMU "translated" copy&paste.
Laurent
next prev parent reply other threads:[~2015-12-12 10:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 20:54 [Qemu-devel] [PATCH 0/1] m68k linux user-space emulation fix (with sign-off this time) Michael Karcher
2015-12-09 20:54 ` [Qemu-devel] [PATCH 1/1] Fix do_rt_sigreturn on m68k linux userspace emulation Michael Karcher
2015-12-09 22:03 ` Laurent Vivier
2015-12-12 9:55 ` Michael Karcher
2015-12-12 10:35 ` Laurent Vivier [this message]
2015-12-09 21:26 ` [Qemu-devel] [PATCH 0/1] m68k linux user-space emulation fix (with sign-off this time) John Paul Adrian Glaubitz
-- strict thread matches above, loose matches on Subject: below --
2015-12-09 20:40 [Qemu-devel] [PATCH 1/1] Fix do_rt_sigreturn on m68k linux userspace emulation Michael Karcher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566BF859.1060704@vivier.eu \
--to=laurent@vivier.eu \
--cc=Michael.Karcher@fu-berlin.de \
--cc=glaubitz@physik.fu-berlin.de \
--cc=karcher@physik.fu-berlin.de \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).