From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8M0b-0003CL-SI for qemu-devel@nongnu.org; Mon, 14 Dec 2015 00:49:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8M0Y-0000dK-Fq for qemu-devel@nongnu.org; Mon, 14 Dec 2015 00:49:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40400) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8M0Y-0000dF-9y for qemu-devel@nongnu.org; Mon, 14 Dec 2015 00:49:14 -0500 References: <1449552513-20341-1-git-send-email-yanmiaobest@gmail.com> <30A41CCC-9E05-409A-AE84-043A3F14A2E8@daynix.com> From: Jason Wang Message-ID: <566E5850.2050902@redhat.com> Date: Mon, 14 Dec 2015 13:49:04 +0800 MIME-Version: 1.0 In-Reply-To: <30A41CCC-9E05-409A-AE84-043A3F14A2E8@daynix.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/4] fix debug macro pattern for vmxnet3 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dmitry Fleytman , Miao Yan Cc: qemu-devel@nongnu.org On 12/08/2015 02:29 PM, Dmitry Fleytman wrote: > > Reviewed-by: Dmitry Fleytman > > >> On 8 Dec 2015, at 07:28 AM, Miao Yan > > wrote: >> >> This patchset fixes debug macro pattern for vmxnet3. The old style uses >> #ifdef...#else...#endif to define debug macros, as a result >> the format string inside the macro will never be checked >> (debug not turned on by default) and is likely to cause build >> errors in the future when enabled. >> >> Changes in v3: >> - fix a build error on 32 bit platforms >> >> Changes in v2: >> - fix grammar errors in commit log >> >> Miao Yan (4): >> net/vmxnet3: fix a build error when enabling debug output >> net/vmxnet3: use %zu for size_t in printf >> net/vmxnet3: fix debug macro pattern for vmxnet3 >> net/vmxnet3: remove redundant VMW_SHPRN(...) definition >> >> hw/net/vmware_utils.h | 5 +- >> hw/net/vmxnet3.c | 8 +-- >> hw/net/vmxnet_debug.h | 139 >> +++++++++++++++++++++++++++++++------------------- >> 3 files changed, 91 insertions(+), 61 deletions(-) >> >> -- >> 1.9.1 >> > Queued for 2.6. Thanks