From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38276)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1a8POq-0000oN-5T
	for qemu-devel@nongnu.org; Mon, 14 Dec 2015 04:26:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1a8POm-0003qC-6B
	for qemu-devel@nongnu.org; Mon, 14 Dec 2015 04:26:32 -0500
Received: from mx2.parallels.com ([199.115.105.18]:50692)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1a8POm-0003q3-1K
	for qemu-devel@nongnu.org; Mon, 14 Dec 2015 04:26:28 -0500
References: <1450081359-7753-1-git-send-email-den@openvz.org>
	<20151214112012-mutt-send-email-mst@redhat.com>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <566E8B39.5070202@openvz.org>
Date: Mon, 14 Dec 2015 12:26:17 +0300
MIME-Version: 1.0
In-Reply-To: <20151214112012-mutt-send-email-mst@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for 2.5? 1/1] DSDT: add floppy-related
	objects
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org, Roman Kagan <rkagan@virtuozzo.com>, Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Richard Henderson <rth@twiddle.net>

On 12/14/2015 12:21 PM, Michael S. Tsirkin wrote:
> On Mon, Dec 14, 2015 at 11:22:39AM +0300, Denis V. Lunev wrote:
>> From: Roman Kagan <rkagan@virtuozzo.com>
>>
>> On x86-based systems Linux determines the presence and the type of
>> floppy drives via a query of a CMOS field.  So does SeaBIOS when
>> populating the return data for int 0x13 function 0x08.
>>
>> Windows doesn't; instead, it requests this information from BIOS via int
>> 0x13/0x08 or through ACPI objects _FDE (Floppy Drive Enumerate) and _FDI
>> (Floppy Drive Information).  On UEFI systems only ACPI-based detection
>> is supported.
>>
>> QEMU used not to provide those objects in its DSDT; as a result floppy
>> drives were invisible to Windows on UEFI/OVMF.
>>
>> This patch implements those objects in ASL, making the ACPI interpreter
>> query the CMOS field and populate the objects.  The data values used for
>> _FDI (which, per ACPI spec, is supposed to be equivalent to BIOS int
>> 0x13/0x08) are taken from SeaBIOS.
>>
>> Signed-off-by: Roman Kagan <rkagan@virtuozzo.com>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Michael S. Tsirkin <mst@redhat.com>
>> CC: Igor Mammedov <imammedo@redhat.com>
>> CC: Paolo Bonzini <pbonzini@redhat.com>
>> CC: Richard Henderson <rth@twiddle.net>
>> CC: Eduardo Habkost <ehabkost@redhat.com>
> This is not a regression, so I'm inclined not to merge this for 2.5.
> Pls correct me if I'm wrong.
>

this was a question actually.

Yes, this is not a regression but user observable bug. The floppy
is not available in Windows UEFI guests and it is not that easy
to get VirtIO drivers in this case installed especially for root
disk.

Den