From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8UaR-0005Vw-5j for qemu-devel@nongnu.org; Mon, 14 Dec 2015 09:58:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8UaQ-0004z4-1L for qemu-devel@nongnu.org; Mon, 14 Dec 2015 09:58:51 -0500 References: <1450061526-5905-1-git-send-email-lszhu@suse.com> From: Eric Blake Message-ID: <566ED914.7070105@redhat.com> Date: Mon, 14 Dec 2015 07:58:28 -0700 MIME-Version: 1.0 In-Reply-To: <1450061526-5905-1-git-send-email-lszhu@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cpjLeWBJPRFxdWXHcv9ecn9SNWSBESpRK" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH V2] fix:readcapacity 10 failure was shown even 16 sent List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhu Lingshan , qemu-block@nongnu.org, "qemu-devel@nongnu.org" Cc: pbonzini@redhat.com, pl@kamp.de, ronniesahlberg@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cpjLeWBJPRFxdWXHcv9ecn9SNWSBESpRK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [adding qemu-devel - ALL patches must cc qemu-devel, even if they are also sent to a sublist like qemu-block] On 12/13/2015 07:52 PM, Zhu Lingshan wrote: > Follow Peter's comment, it is the patch V2. This sentence should appear... > This patch can fix that error: readcapacity 10 failure will shown even = it was readcapacity16 sent. Long line; try to keep commit messages wrapped around 72 or fewer characters, since 'git log' will display it with indentation and you still want to read it all in an 80-column window. Subject line is a bit awkward; I suggest: iscsi: fix readcapacity error message The error message for readcapacity 16 incorrectly mentioned a readcapacity 10 failure. >=20 > Signed-off-by: Zhu Lingshan > --- =2E..here, since it explains why you sent v2, but will make no sense a year from now when browsing just qemu.git. > block/iscsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/block/iscsi.c b/block/iscsi.c > index bd1f1bf..bd3473e 100644 > --- a/block/iscsi.c > +++ b/block/iscsi.c > @@ -1270,7 +1270,7 @@ static void iscsi_readcapacity_sync(IscsiLun *isc= silun, Error **errp) > && retries-- > 0); > =20 > if (task =3D=3D NULL || task->status !=3D SCSI_STATUS_GOOD) { > - error_setg(errp, "iSCSI: failed to send readcapacity10 command= =2E"); > + error_setg(errp, "iSCSI: failed to send readcapacity10/16 comm= and."); While you're touching this, please also drop the trailing '.' > } else if (!iscsilun->block_size || > iscsilun->block_size % BDRV_SECTOR_SIZE) { > error_setg(errp, "iSCSI: the target returned an invalid " >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cpjLeWBJPRFxdWXHcv9ecn9SNWSBESpRK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWbtkhAAoJEKeha0olJ0NqdEQH/2nzb3pubyAALrzU1Sq2kY0W CA1S6XonG/SUm0aE5FMFHTXnd6vQWytehulHpZIM4IuGdAxT+PcfYZEovfS/56NV VLqy3Vl43dLYmncWByfk3S/fo7HMXEiMTZ9rt6Zb5h6l9/LVqAT32cNEhd97gRSX TXmlbsNebb9oGXeus0829OJzxzzSZikS5wxrxUkgODMZIhJigIKzYwojwzhpsRUv lpgse1nxeM0d3tsgA4fLOll+sKyFnfpQuDcWyxPrxGuVIMI6eNwAhyaTOPmxzlOh apiuDmTHqSYtoc9U/6zdDHqCdX3hf6mLWG7lFHBtdaafxqHMQ8HWc8S3SwpZfS0= =8xOT -----END PGP SIGNATURE----- --cpjLeWBJPRFxdWXHcv9ecn9SNWSBESpRK--