* Re: [Qemu-devel] [Qemu-block] [PATCH V2] fix:readcapacity 10 failure was shown even 16 sent
[not found] <1450061526-5905-1-git-send-email-lszhu@suse.com>
@ 2015-12-14 14:58 ` Eric Blake
0 siblings, 0 replies; only message in thread
From: Eric Blake @ 2015-12-14 14:58 UTC (permalink / raw)
To: Zhu Lingshan, qemu-block, qemu-devel@nongnu.org
Cc: pbonzini, pl, ronniesahlberg
[-- Attachment #1: Type: text/plain, Size: 1813 bytes --]
[adding qemu-devel - ALL patches must cc qemu-devel, even if they are
also sent to a sublist like qemu-block]
On 12/13/2015 07:52 PM, Zhu Lingshan wrote:
> Follow Peter's comment, it is the patch V2.
This sentence should appear...
> This patch can fix that error: readcapacity 10 failure will shown even it was readcapacity16 sent.
Long line; try to keep commit messages wrapped around 72 or fewer
characters, since 'git log' will display it with indentation and you
still want to read it all in an 80-column window.
Subject line is a bit awkward; I suggest:
iscsi: fix readcapacity error message
The error message for readcapacity 16 incorrectly mentioned a
readcapacity 10 failure.
>
> Signed-off-by: Zhu Lingshan <lszhu@suse.com>
> ---
...here, since it explains why you sent v2, but will make no sense a
year from now when browsing just qemu.git.
> block/iscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index bd1f1bf..bd3473e 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -1270,7 +1270,7 @@ static void iscsi_readcapacity_sync(IscsiLun *iscsilun, Error **errp)
> && retries-- > 0);
>
> if (task == NULL || task->status != SCSI_STATUS_GOOD) {
> - error_setg(errp, "iSCSI: failed to send readcapacity10 command.");
> + error_setg(errp, "iSCSI: failed to send readcapacity10/16 command.");
While you're touching this, please also drop the trailing '.'
> } else if (!iscsilun->block_size ||
> iscsilun->block_size % BDRV_SECTOR_SIZE) {
> error_setg(errp, "iSCSI: the target returned an invalid "
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] only message in thread