From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8Up0-00047N-EJ for qemu-devel@nongnu.org; Mon, 14 Dec 2015 10:13:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8Uow-0001CY-DX for qemu-devel@nongnu.org; Mon, 14 Dec 2015 10:13:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8Uow-0001CL-5r for qemu-devel@nongnu.org; Mon, 14 Dec 2015 10:13:50 -0500 References: <1450105357-8516-1-git-send-email-peter.maydell@linaro.org> From: Eric Blake Message-ID: <566EDCA7.7010009@redhat.com> Date: Mon, 14 Dec 2015 08:13:43 -0700 MIME-Version: 1.0 In-Reply-To: <1450105357-8516-1-git-send-email-peter.maydell@linaro.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jjnUC40eqH22laotUiWMhT4Tm28gBA3IP" Subject: Re: [Qemu-devel] [PATCH for-2.5??] configure: Fix shell syntax to placate OpenBSD's pdksh List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: patches@linaro.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jjnUC40eqH22laotUiWMhT4Tm28gBA3IP Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/14/2015 08:02 AM, Peter Maydell wrote: > Unfortunately the OpenBSD pdksh does not like brackets inside > the right part of a ${variable+word} parameter expansion: >=20 > $ echo "${a+($b)}" > ksh: ${a+($b)}": bad substitution >=20 > though both bash and dash accept them. In any case this line > was causing odd output in the case where nettle is not present: > nettle no () >=20 > (because if nettle is not present then $nettle will be "no", > not a null string or unset). >=20 > Rewrite it to just use an if. >=20 > This bug was originally introduced in becaeb726 and was present > in the 2.4.0 release. >=20 > Fixes: https://bugs.launchpad.net/qemu/+bug/1525682 > Reported-by: Dmitrij D. Czarkoff > Signed-off-by: Peter Maydell > --- > This fixes a problem where configure just falls over on OpenBSD, > but on the other hand it is not a regression since 2.4.0... > Opinions on whether we should put it in 2.5 as a last minute > thing welcome. Can OpenBSD users do: /path/to/bash ./configure to work around it? That, and the fact that we went an entire release cycle without a report of a problem, means few developers are even attempting OpenBSD builds. So, I would argue that as a non-regression, and where there is a likely workaround of using a different shell, this can wait until 2.6. >=20 > configure | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/configure b/configure > index b9552fd..6ca6c64 100755 > --- a/configure > +++ b/configure > @@ -4758,7 +4758,11 @@ echo "GTK GL support $gtk_gl" > echo "GNUTLS support $gnutls" > echo "GNUTLS hash $gnutls_hash" > echo "libgcrypt $gcrypt" > -echo "nettle $nettle ${nettle+($nettle_version)}" > +if test "$nettle" =3D "yes"; then > + echo "nettle $nettle ($nettle_version)" > +else > + echo "nettle $nettle" > +fi At any rate, Reviewed-by: Eric Blake > echo "libtasn1 $tasn1" > echo "VTE support $vte" > echo "curses support $curses" >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jjnUC40eqH22laotUiWMhT4Tm28gBA3IP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWbtysAAoJEKeha0olJ0NqXGEH/Rkx7dU0zJIpEUH+gvOdfPZI iggOBROfc1Wx5X9nc2J+GhSKKA57SofvwDdCBd9oZUk9qAIZAdX9AO9cPHp4xl7g RoLhK2Nl2P30/re1BZgXsskh0ssVbuH4qREyaJGnAS1EDl8QuFgFD+uxa4jnL1Z6 jxwaqD1e6VCVgW+qf+nSugTa5TVxQ/2xwdXigBzUFKdojF+SB+b16TB/c7OFhua/ A7nv6zn+KBjP4gb/MuILLq5vb7R+SNWHZW1Z++eyc+1j7eYE9Ui8XA5DPNYNPZZH YaaSIHy6b6sdVU74TrYzE+8sfzqgpm0oNmptOUkkUhPQDfdUpV+mqq/TpwnKoe4= =IQzv -----END PGP SIGNATURE----- --jjnUC40eqH22laotUiWMhT4Tm28gBA3IP--