qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Vincenzo Maffione <v.maffione@gmail.com>, qemu-devel@nongnu.org
Cc: g.lettieri@iet.unipi.it, jasowang@redhat.com, rizzo@iet.unipi.it,
	armbru@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH RFC] virtio: proposal to optimize accesses to VQs
Date: Mon, 14 Dec 2015 17:06:26 +0100	[thread overview]
Message-ID: <566EE902.8040402@redhat.com> (raw)
In-Reply-To: <1450104679-24921-1-git-send-email-v.maffione@gmail.com>



On 14/12/2015 15:51, Vincenzo Maffione wrote:
> 
> This patch slightly rewrites the code to reduce the number of accesses, since
> many of them seems unnecessary to me. After this reduction, the bottleneck
> jumps from 1 Mpps to 2 Mpps.
> 
> Patch is not complete (e.g. it still does not properly manage endianess, it is
> not clean, etc.). I just wanted to ask if you think the idea makes sense, and
> a proper patch in this direction would be accepted.

Yes, definitely.   I have even done a very similar change here:

	http://article.gmane.org/gmane.comp.emulators.qemu.block/6620

Can you review that patch, and possibly work on top of it?

Thanks,

Paolo

  parent reply	other threads:[~2015-12-14 16:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-14 14:51 [Qemu-devel] [PATCH RFC] virtio: proposal to optimize accesses to VQs Vincenzo Maffione
2015-12-14 14:51 ` [Qemu-devel] [PATCH RFC] virtio: optimize access to guest physical memory Vincenzo Maffione
2015-12-14 16:06 ` Paolo Bonzini [this message]
2015-12-14 17:16   ` [Qemu-devel] [PATCH RFC] virtio: proposal to optimize accesses to VQs Vincenzo Maffione
2015-12-15  9:22   ` Vincenzo Maffione
2015-12-15 10:34     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=566EE902.8040402@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=g.lettieri@iet.unipi.it \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rizzo@iet.unipi.it \
    --cc=v.maffione@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).