From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8VeL-0005q9-LQ for qemu-devel@nongnu.org; Mon, 14 Dec 2015 11:06:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8VeG-0006KU-Ld for qemu-devel@nongnu.org; Mon, 14 Dec 2015 11:06:57 -0500 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:37764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8VeG-0006Js-Fh for qemu-devel@nongnu.org; Mon, 14 Dec 2015 11:06:52 -0500 Received: by wmnn186 with SMTP id n186so127393437wmn.0 for ; Mon, 14 Dec 2015 08:06:52 -0800 (PST) Sender: Paolo Bonzini References: <1450104679-24921-1-git-send-email-v.maffione@gmail.com> From: Paolo Bonzini Message-ID: <566EE902.8040402@redhat.com> Date: Mon, 14 Dec 2015 17:06:26 +0100 MIME-Version: 1.0 In-Reply-To: <1450104679-24921-1-git-send-email-v.maffione@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC] virtio: proposal to optimize accesses to VQs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vincenzo Maffione , qemu-devel@nongnu.org Cc: g.lettieri@iet.unipi.it, jasowang@redhat.com, rizzo@iet.unipi.it, armbru@redhat.com, mst@redhat.com On 14/12/2015 15:51, Vincenzo Maffione wrote: > > This patch slightly rewrites the code to reduce the number of accesses, since > many of them seems unnecessary to me. After this reduction, the bottleneck > jumps from 1 Mpps to 2 Mpps. > > Patch is not complete (e.g. it still does not properly manage endianess, it is > not clean, etc.). I just wanted to ask if you think the idea makes sense, and > a proper patch in this direction would be accepted. Yes, definitely. I have even done a very similar change here: http://article.gmane.org/gmane.comp.emulators.qemu.block/6620 Can you review that patch, and possibly work on top of it? Thanks, Paolo