From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8Wi7-00025L-57 for qemu-devel@nongnu.org; Mon, 14 Dec 2015 12:14:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8Wi0-0007KC-2f for qemu-devel@nongnu.org; Mon, 14 Dec 2015 12:14:55 -0500 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:34623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8Whz-0007K6-MK for qemu-devel@nongnu.org; Mon, 14 Dec 2015 12:14:47 -0500 Received: by mail-wm0-x234.google.com with SMTP id p66so72259895wmp.1 for ; Mon, 14 Dec 2015 09:14:47 -0800 (PST) Sender: Paolo Bonzini References: <1449994112-7054-1-git-send-email-shmulik.ladkani@ravellosystems.com> <1449994112-7054-6-git-send-email-shmulik.ladkani@ravellosystems.com> From: Paolo Bonzini Message-ID: <566EF8FD.3080206@redhat.com> Date: Mon, 14 Dec 2015 18:14:37 +0100 MIME-Version: 1.0 In-Reply-To: <1449994112-7054-6-git-send-email-shmulik.ladkani@ravellosystems.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shmulik Ladkani , Dmitry Fleytman Cc: Marcel Apfelbaum , idan.brown@ravellosystems.com, qemu-devel@nongnu.org, "Michael S. Tsirkin" On 13/12/2015 09:08, Shmulik Ladkani wrote: > + pvs_k->parent_dc_realize = dc->realize; Marcel, Michael, this creates a really nasty dependency on the contents of pci_qdev_realize. Can you instead change PCIDeviceClass's pc->is_express to a function pointer, and provide a sample implementation pci_is_express_true for the devices that set is_express to true? Thanks, Paolo