From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8XUL-0002x8-Kh for qemu-devel@nongnu.org; Mon, 14 Dec 2015 13:04:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8XUG-0004oj-BL for qemu-devel@nongnu.org; Mon, 14 Dec 2015 13:04:45 -0500 Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]:37871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8XUG-0004of-1P for qemu-devel@nongnu.org; Mon, 14 Dec 2015 13:04:40 -0500 Received: by wmnn186 with SMTP id n186so132259232wmn.0 for ; Mon, 14 Dec 2015 10:04:39 -0800 (PST) Sender: Paolo Bonzini References: <1449994112-7054-1-git-send-email-shmulik.ladkani@ravellosystems.com> <1449994112-7054-7-git-send-email-shmulik.ladkani@ravellosystems.com> <566EF753.4070605@redhat.com> <20151214190935-mutt-send-email-mst@redhat.com> <163895392.40236889.1450114130220.JavaMail.zimbra@redhat.com> <20151214193220-mutt-send-email-mst@redhat.com> From: Paolo Bonzini Message-ID: <566F04B1.8070204@redhat.com> Date: Mon, 14 Dec 2015 19:04:33 +0100 MIME-Version: 1.0 In-Reply-To: <20151214193220-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Dmitry Fleytman , Marcel Apfelbaum , idan brown , Shmulik Ladkani , qemu-devel@nongnu.org On 14/12/2015 18:35, Michael S. Tsirkin wrote: > > What distinguishes an internal from an external property? Everything > > except links to backends would be "internal". > > How do you mean? We have a ton of properties e.g. > to control which offloads are allowed for virtio net. Why would users set them? > It's set internally by machine types to avoid breaking > migration. I don't see any reason for users to set it. But they do set it :) albeit only through machine types. I don't think it's different from offloads, just much more specialized. Or do you mean that it could go away if we decide to remove very old machine types? I think we would remove compat properties connected to those machine types as well, even without "x-". Paolo