From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8XV8-0003w0-Nx for qemu-devel@nongnu.org; Mon, 14 Dec 2015 13:05:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8XV2-0004z5-Qd for qemu-devel@nongnu.org; Mon, 14 Dec 2015 13:05:34 -0500 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:35899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8XV2-0004yz-Kd for qemu-devel@nongnu.org; Mon, 14 Dec 2015 13:05:28 -0500 Received: by mail-wm0-x232.google.com with SMTP id n186so130225583wmn.1 for ; Mon, 14 Dec 2015 10:05:28 -0800 (PST) Sender: Paolo Bonzini References: <1449994112-7054-1-git-send-email-shmulik.ladkani@ravellosystems.com> <1449994112-7054-6-git-send-email-shmulik.ladkani@ravellosystems.com> <566EF8FD.3080206@redhat.com> <20151214173729.GA14061@redhat.com> From: Paolo Bonzini Message-ID: <566F04E6.4080908@redhat.com> Date: Mon, 14 Dec 2015 19:05:26 +0100 MIME-Version: 1.0 In-Reply-To: <20151214173729.GA14061@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Dmitry Fleytman , Marcel Apfelbaum , idan.brown@ravellosystems.com, Shmulik Ladkani , qemu-devel@nongnu.org On 14/12/2015 18:37, Michael S. Tsirkin wrote: > > Can you instead change PCIDeviceClass's pc->is_express to a function > > pointer, and provide a sample implementation pci_is_express_true for the > > devices that set is_express to true? > > I'm not very familiar with vmw code, and I dislike overusing callbacks. > What exactly would this callback do? It would be exactly the same for virtio. The callback would return true if the device should have a PCIe capability, false if not. The default would be always false. Paolo