From: Max Reitz <mreitz@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 0/5] block: allow partial info-block query
Date: Mon, 14 Dec 2015 21:46:00 +0100 [thread overview]
Message-ID: <566F2A88.60706@redhat.com> (raw)
In-Reply-To: <1450122916-4706-1-git-send-email-jsnow@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1855 bytes --]
On 14.12.2015 20:55, John Snow wrote:
> Allow info-block to succeed even when it cannot reconstruct filenames,
> but be explicit about this failure. Utilities that rely on the current
> behavior are modified to report this explicit failure to users.
>
> v3:
> - Fix qemu-img output such that "backing file IS the absolute backing path"
> and "absolute backing path was indeterminate" are distinguishable via
> a new error message present in block/qapi.c; see patch 3.
> - Output for test 110 modified once more to expect the above error.
>
> v2:
> - Fix qemu-img from now choking when it gets a partial response.
>
> ________________________________________________________________________________
>
> For convenience, this branch is available at:
> https://github.com/jnsnow/qemu.git branch block-allow-partial-query
> https://github.com/jnsnow/qemu/tree/block-allow-partial-query
>
> This version is tagged block-allow-partial-query-v3:
> https://github.com/jnsnow/qemu/releases/tag/block-allow-partial-query-v3
>
> John Snow (5):
> block/qapi: do not redundantly print "actual path"
> block/qapi: always report full_backing_filename
> block/qapi: explicitly warn if !has_full_backing_filename
> qemu-img: abort when full_backing_filename not present
> block/qapi: allow best-effort query
>
> block/qapi.c | 19 ++++++++++++-------
> qemu-img.c | 5 ++++-
> tests/qemu-iotests/043.out | 2 ++
> tests/qemu-iotests/110.out | 5 ++++-
> 4 files changed, 22 insertions(+), 9 deletions(-)
Due to Markus not being CC'd and the get_maintainers script giving both
him and Kevin, I just went ahead and...
...fixed patch 3's commit message and applied the series to my
block-next branch, thanks:
https://github.com/XanClic/qemu/commits/block-next
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-12-14 20:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 19:55 [Qemu-devel] [PATCH v3 0/5] block: allow partial info-block query John Snow
2015-12-14 19:55 ` [Qemu-devel] [PATCH v3 1/5] block/qapi: do not redundantly print "actual path" John Snow
2015-12-14 19:55 ` [Qemu-devel] [PATCH v3 2/5] block/qapi: always report full_backing_filename John Snow
2015-12-14 19:55 ` [Qemu-devel] [PATCH v3 3/5] block/qapi: explicitly warn if !has_full_backing_filename John Snow
2015-12-14 20:06 ` Max Reitz
2015-12-14 20:11 ` Max Reitz
2015-12-14 19:55 ` [Qemu-devel] [PATCH v3 4/5] qemu-img: abort when full_backing_filename not present John Snow
2015-12-14 19:55 ` [Qemu-devel] [PATCH v3 5/5] block/qapi: allow best-effort query John Snow
2015-12-14 20:06 ` Max Reitz
2015-12-14 20:46 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566F2A88.60706@redhat.com \
--to=mreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).