From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39148)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1a8jOe-0006kI-Dr
	for qemu-devel@nongnu.org; Tue, 15 Dec 2015 01:47:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1a8jOb-00063Q-92
	for qemu-devel@nongnu.org; Tue, 15 Dec 2015 01:47:40 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48642)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1a8jOb-00063E-34
	for qemu-devel@nongnu.org; Tue, 15 Dec 2015 01:47:37 -0500
References: <20151214134939.GA3142@var.bordeaux.inria.fr>
	<1450101088-14575-1-git-send-email-samuel.thibault@ens-lyon.org>
	<1450101088-14575-3-git-send-email-samuel.thibault@ens-lyon.org>
	<566F0179.50209@redhat.com> <20151214220616.GB2967@var.home>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <566FB781.7060000@redhat.com>
Date: Tue, 15 Dec 2015 07:47:29 +0100
MIME-Version: 1.0
In-Reply-To: <20151214220616.GB2967@var.home>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/9] slirp: Adding address family switch
 for incoming frames
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org, Vasiliy Tolstov <v.tolstov@selfip.ru>, Dave Gilbert <dgilbert@redhat.com>, Gonglei <arei.gonglei@huawei.com>, Jan Kiszka <jan.kiszka@siemens.com>, Huangpeng <peter.huangpeng@huawei.com>, Guillaume Subiron <maethor@subiron.org>

On 14/12/15 23:06, Samuel Thibault wrote:
> Thomas Huth, on Mon 14 Dec 2015 18:50:49 +0100, wrote:
>>> +    default:
>>> +        /* Do not assert while we don't manage IP6VERSION */
>>> +        /* assert(0); */
>>
>> Not sure if we ever want to have an assert() here - since I assume this
>> could be triggered by the guest?
> 
> No, this is if_encap, so packets that slirp builds for the guest, so it
> shouldn't ever happen. The input side is in slirp_input(), which just
> ignores frames with unknown protocol.

OK, in that case the assert() is of course the right choice. Thanks for
the explanation!

 Thomas