From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39667)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1a8nVZ-00006p-5B
	for qemu-devel@nongnu.org; Tue, 15 Dec 2015 06:11:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1a8nVU-00065S-Um
	for qemu-devel@nongnu.org; Tue, 15 Dec 2015 06:11:04 -0500
Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:33669)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1a8nVU-00065K-Oi
	for qemu-devel@nongnu.org; Tue, 15 Dec 2015 06:11:00 -0500
Received: by mail-wm0-x22c.google.com with SMTP id n186so88822600wmn.0
	for <qemu-devel@nongnu.org>; Tue, 15 Dec 2015 03:11:00 -0800 (PST)
References: <1449859353-1574-1-git-send-email-ehabkost@redhat.com>
	<1449859353-1574-2-git-send-email-ehabkost@redhat.com>
From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Message-ID: <566FF540.5080108@gmail.com>
Date: Tue, 15 Dec 2015 13:10:56 +0200
MIME-Version: 1.0
In-Reply-To: <1449859353-1574-2-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 01/14] q35: Remove
 MCHPCIState.guest_info field
Reply-To: marcel@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.a@redhat.com>

On 12/11/2015 08:42 PM, Eduardo Habkost wrote:
> The field is not used for anything.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>   hw/i386/pc_q35.c          | 1 -
>   include/hw/pci-host/q35.h | 1 -
>   2 files changed, 2 deletions(-)
>
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index 9da751b..43ee8bb 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -176,7 +176,6 @@ static void pc_q35_init(MachineState *machine)
>       q35_host->mch.address_space_io = get_system_io();
>       q35_host->mch.below_4g_mem_size = pcms->below_4g_mem_size;
>       q35_host->mch.above_4g_mem_size = pcms->above_4g_mem_size;
> -    q35_host->mch.guest_info = guest_info;
>       /* pci */
>       qdev_init_nofail(DEVICE(q35_host));
>       phb = PCI_HOST_BRIDGE(q35_host);
> diff --git a/include/hw/pci-host/q35.h b/include/hw/pci-host/q35.h
> index dbe6dc0..c5c073d 100644
> --- a/include/hw/pci-host/q35.h
> +++ b/include/hw/pci-host/q35.h
> @@ -59,7 +59,6 @@ typedef struct MCHPCIState {
>       ram_addr_t below_4g_mem_size;
>       ram_addr_t above_4g_mem_size;
>       uint64_t pci_hole64_size;
> -    PcGuestInfo *guest_info;
>       uint32_t short_root_bus;
>       IntelIOMMUState *iommu;
>   } MCHPCIState;
>

So nobody is using it.


Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>