From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41782)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1a8ndr-0003HR-Ij
	for qemu-devel@nongnu.org; Tue, 15 Dec 2015 06:19:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1a8ndo-00006X-CU
	for qemu-devel@nongnu.org; Tue, 15 Dec 2015 06:19:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38924)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1a8ndo-00006P-8K
	for qemu-devel@nongnu.org; Tue, 15 Dec 2015 06:19:36 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (Postfix) with ESMTPS id 4A6BAC0ABF2E
	for <qemu-devel@nongnu.org>; Tue, 15 Dec 2015 11:19:35 +0000 (UTC)
References: <1449859353-1574-1-git-send-email-ehabkost@redhat.com>
	<1449859353-1574-4-git-send-email-ehabkost@redhat.com>
From: Marcel Apfelbaum <marcel@redhat.com>
Message-ID: <566FF744.6040906@redhat.com>
Date: Tue, 15 Dec 2015 13:19:32 +0200
MIME-Version: 1.0
In-Reply-To: <1449859353-1574-4-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 03/14] pc: Move PcGuestInfo declaration
	to top of file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>, Marcel Apfelbaum <marcel.a@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

On 12/11/2015 08:42 PM, Eduardo Habkost wrote:
> The struct will be used inside PCMachineState.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>   include/hw/i386/pc.h | 31 ++++++++++++++++---------------
>   1 file changed, 16 insertions(+), 15 deletions(-)
>
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 9503dbb..84bc88f 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -20,6 +20,22 @@
>
>   #define HPET_INTCAP "hpet-intcap"
>
> +/* Machine info for ACPI build: */
> +struct PcGuestInfo {
> +    bool isapc_ram_fw;
> +    hwaddr ram_size, ram_size_below_4g;
> +    unsigned apic_id_limit;
> +    bool apic_xrupt_override;
> +    uint64_t numa_nodes;
> +    uint64_t *node_mem;
> +    uint64_t *node_cpu;
> +    FWCfgState *fw_cfg;
> +    int legacy_acpi_table_size;
> +    bool has_acpi_build;
> +    bool has_reserved_memory;
> +    bool rsdp_in_ram;
> +};
> +
>   /**
>    * PCMachineState:
>    * @acpi_dev: link to ACPI PM device that performs ACPI hotplug handling
> @@ -133,21 +149,6 @@ typedef struct PcPciInfo {
>   #define ACPI_PM_PROP_GPE0_BLK_LEN "gpe0_blk_len"
>   #define ACPI_PM_PROP_TCO_ENABLED "enable_tco"
>
> -struct PcGuestInfo {
> -    bool isapc_ram_fw;
> -    hwaddr ram_size, ram_size_below_4g;
> -    unsigned apic_id_limit;
> -    bool apic_xrupt_override;
> -    uint64_t numa_nodes;
> -    uint64_t *node_mem;
> -    uint64_t *node_cpu;
> -    FWCfgState *fw_cfg;
> -    int legacy_acpi_table_size;
> -    bool has_acpi_build;
> -    bool has_reserved_memory;
> -    bool rsdp_in_ram;
> -};
> -
>   /* parallel.c */
>
>   void parallel_hds_isa_init(ISABus *bus, int n);
>

Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>