From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bcZa0-0001wr-BS for qemu-devel@nongnu.org; Wed, 24 Aug 2016 10:55:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bcZZv-0004jm-Da for qemu-devel@nongnu.org; Wed, 24 Aug 2016 10:54:59 -0400 Sender: Richard Henderson References: <1472012279-20581-1-git-send-email-rth@twiddle.net> <20160824043048.109542.39014@ex-std-node742.prod.rhcloud.com> <535318f1-8178-714d-7487-5aeb0661280b@redhat.com> From: Richard Henderson Message-ID: <566a869d-1042-0bb7-7a4b-928efa5ea676@twiddle.net> Date: Wed, 24 Aug 2016 07:53:37 -0700 MIME-Version: 1.0 In-Reply-To: <535318f1-8178-714d-7487-5aeb0661280b@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, famz@redhat.com, vijay.kilari@gmail.com On 08/23/2016 09:38 PM, Paolo Bonzini wrote: > > > On 24/08/2016 06:30, no-reply@patchew.org wrote: >> ERROR: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt >> #44: FILE: util/cutils.c:289: >> + __asm volatile("vmovdqu -0x80(%1),%0\n\t" > > Other errors can be ignored, but please use __asm__ __volatile__ here or > just __asm__ (I don't think volatile is useful). I had to add volatile to keep the prefetch in advance of the loop. I suppose I could just add the prefetch to the asm block... > Also, perhaps move this function to its own file since you're rewriting > it anyway? Sure. r~