From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15038C3DA63 for ; Tue, 23 Jul 2024 09:09:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWBVk-0003uj-4K; Tue, 23 Jul 2024 05:08:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWBVi-0003tW-JJ for qemu-devel@nongnu.org; Tue, 23 Jul 2024 05:08:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWBVf-00021r-KX for qemu-devel@nongnu.org; Tue, 23 Jul 2024 05:08:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721725717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tWXepFXEMQwgQdJ9vP+tEGWvhxEy37MSzkWIEppp70I=; b=ZT7breX0rHhoqtXs1E4O2yHi1UtFIGkW2mQTzTOuRKY6tqDQatoNleAToeqAWk6Fa3Kv2g E+fLs9Fr3ow8rzzrx3Bsa4QnaNTO5qf2vqv9HP2bjkqvbdN0YSKVSb8y2HUhG8B0jXmmQq mNQboAgmtxiA8EELabWCebFs/uMrYQQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-m7kJjy0gNs2vpU-eOc4tAg-1; Tue, 23 Jul 2024 05:08:35 -0400 X-MC-Unique: m7kJjy0gNs2vpU-eOc4tAg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4279c75c44dso37733595e9.2 for ; Tue, 23 Jul 2024 02:08:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721725714; x=1722330514; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tWXepFXEMQwgQdJ9vP+tEGWvhxEy37MSzkWIEppp70I=; b=AHbKn9kHOMscj3oU3AOSpnYaTYOsiGa8osXVoqJ5gOUGKgV+ZLJNP9PpbVTe5PTsbl 97Xcs5jKZgs6zqZWV6q+V/V7S346gXi9Mm+EBa7REWlqzgzHFxRBn70diJrxv/kSTtDp meNX4ZHZlLOaQWBbfxgNvk+CawNATaP3217lKvv5/x8+7D6FHs5KuiiMNK/JFVh8be/d +/TV7Bq+qW6GqPlu5KI0TBh3soUVDr0Zh1VUj9HbGXGMWbSSd/t7n68vU0nIoicLlp42 3akaizVMKucdVNrbwourauJEjOMGFtSMJjs2T90lwaMTioHG8D34pAcwPg8KlLNGVKkW TpZQ== X-Forwarded-Encrypted: i=1; AJvYcCWWHWtQ2Dxmpi+lIhrp5jFkygCslD+4ZVnZtRO1hPnqvq4KXKbKXLYp46pyigCDbrdTV4cSzMUXs/Qq7VwgKlq1HJloEtE= X-Gm-Message-State: AOJu0Yx/B3GIhPMza1+DATM4dVyjixf61c9xopukNfEQqStSGzFpQVcE B9Zv4ETEWB60tZ2iqcjMYRYXxr/N4p/dI0hHhuqkilBUfDmQYw8wcXpQh4r10oXKGapLcRSa6Mp 12kG3PO4yzCicqq2KBspnDtiZE4v0/J1eCduuJHawL3VnnQo5o+BjuxAKBca4 X-Received: by 2002:a05:600c:1906:b0:426:4765:16f7 with SMTP id 5b1f17b1804b1-427dc529337mr58947395e9.21.1721725714076; Tue, 23 Jul 2024 02:08:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHQheCZyrBFS7GMr6pPy3U5qvnRC4ol3Hsmd5L3qcAPnRF7/CVLTWthxDfeqBsnGrTFpFvdOg== X-Received: by 2002:a05:600c:1906:b0:426:4765:16f7 with SMTP id 5b1f17b1804b1-427dc529337mr58947235e9.21.1721725713586; Tue, 23 Jul 2024 02:08:33 -0700 (PDT) Received: from ?IPV6:2a01:e0a:9e2:9000:bed7:42c6:fb19:d12e? ([2a01:e0a:9e2:9000:bed7:42c6:fb19:d12e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427d2a3b763sm191518885e9.10.2024.07.23.02.08.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jul 2024 02:08:33 -0700 (PDT) Message-ID: <566d3ebb-4999-4ffb-a18c-b6721abed5c5@redhat.com> Date: Tue, 23 Jul 2024 11:08:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 0/9] hw/iommufd: IOMMUFD Dirty Tracking To: Joao Martins , qemu-devel@nongnu.org Cc: Yi Liu , Eric Auger , Zhenzhong Duan , Alex Williamson , Jason Gunthorpe , Avihai Horon References: <20240722211326.70162-1-joao.m.martins@oracle.com> <11941abb-d401-4056-b293-ef5f1fd3756d@redhat.com> <511424c2-90e3-4751-9776-1a677b6ecf15@oracle.com> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= In-Reply-To: <511424c2-90e3-4751-9776-1a677b6ecf15@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.133, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 7/23/24 10:56, Joao Martins wrote: > On 23/07/2024 09:35, Cédric Le Goater wrote: >> On 7/22/24 23:13, Joao Martins wrote: >>> This small series adds support for IOMMU dirty tracking support via the >>> IOMMUFD backend. The hardware capability is available on most recent x86 >>> hardware (and these SMMUv3 in upcoming v6.11). The series is divided >>> organized as follows: >>> >>> * Patches 1 - 7: IOMMUFD backend support for dirty tracking; >>> >>> Introduce auto domains -- Patch 3 goes into more detail, but the gist is that >>> we will find and attach a device to a compatible IOMMU domain, or allocate a new >>> hardware pagetable *or* rely on kernel IOAS attach (for mdevs). Afterwards the >>> workflow is relatively simple: >>> >>> 1) Probe device and allow dirty tracking in the HWPT >>> 2) Toggling dirty tracking on/off >>> 3) Read-and-clear of Dirty IOVAs >>> >>> The heuristics selected for (1) were to always request the HWPT for >>> dirty tracking if supported, or rely on device dirty page tracking. This >>> is a little simplistic and we aren't necessarily utilizing IOMMU dirty >>> tracking even if we ask during hwpt allocation. >>> >>> The unmap case is deferred until further vIOMMU support with migration >>> is added[3] which will then introduce the usage of >>> IOMMU_HWPT_GET_DIRTY_BITMAP_NO_CLEAR in GET_DIRTY_BITMAP ioctl in the >>> dma unmap bitmap flow. >>> >>> * Patches 8 - 9: Don't block live migration where there's no VF dirty >>> tracker, considering that we have IOMMU dirty tracking. >>> >>> Comments and feedback appreciated (on patches 1, 5, 8, 9) >>> >>> Cheers, >>>      Joao >>> >>> P.S. Suggest v6.11-rc as hypervisor kernel as there's >>> some bugs fixed there with regards to IOMMU hugepage dirty tracking. >>> >>> Changes since v5[6]: >>> * Remove patches 1-4 as these were commited to vfio-next >>> * Add the Rb by Cedric and Zhenzhong (previously patches 7, 8, 10, 11) >>> * Introduce VFIODevice::iommu_dirty_tracking and use it on patch 5, 8 >>> to store whether we can use IOMMU dirty tracking. >>> >>> Changes since v4[5]: >>> * Add various Reviewed-by in patches 2,3,4,6,8,11 >>> * Change error messages to mention IOMMU (Zhenzhong) >>> * Better improve the checking of dirty page tracking in >>>    vfio_migration_realize() to detect per-device IOMMU instead of using >>>    container dirty_page_supported(). >>> * Improve various commit messages (Eric) >>> * Extract the caps::hw_caps into its own patch as it was miosleading to >>> be hidden in another patch (new patch 7) >>> * Restructure patch 1 helper to be vfio_device_is_mdev() and use >>> vfio::mdev directly in rest of patches (Cedric) >>> * Improve error messages of set,query dirty tracking (Cedric) >>> * Add missing casts to uintptr and uint64_t* (Cedric) >>> * Add missing commens to struct doc from aw_bits removal (and hw_caps >>> addition) (Eric) >>> * Fix the detach flow in auto domains (Eric) >>> * Set hwpt to NULL on detach (Eric) >>> * Spurious line (Eric) >>> >>> Changes since v3[5]: >>> * Skip HostIOMMUDevice::realize for mdev, and introduce a helper to check if >>> the VFIO >>>    device is mdev. (Zhenzhong) >>> * Skip setting IOMMU device for mdev (Zhenzhong) >>> * Add Zhenzhong review tag in patch 3 >>> * Utilize vbasedev::bcontainer::dirty_pages_supported instead of introducing >>>    a new HostIOMMUDevice capability and thus remove the cap patch from the >>> series (Zhenzhong) >>> * Move the HostIOMMUDevice::realize() to be part of VFIODevice initialization >>> in attach_device() >>> while skipping it all together for mdev. (Cedric) >>> * Due to the previous item, had to remove aw_bits because it depends on device >>> attach being >>> finished, instead defer it to when get_cap() gets called. >>> * Skip auto domains for mdev instead of purposedly erroring out (Zhenzhong) >>> * Pass errp in all cases, and instead just free the error in case of -EINVAL >>>    in most of all patches, and also pass Error* in >>> iommufd_backend_alloc_hwpt() amd >>>    set/query dirty. This is made better thanks in part to skipping auto >>> domains for mdev (Cedric) >>> >>> Changes since RFCv2[4]: >>> * Always allocate hwpt with IOMMU_HWPT_ALLOC_DIRTY_TRACKING even if >>> we end up not actually toggling dirty tracking. (Avihai) >>> * Fix error handling widely in auto domains logic and all patches (Avihai) >>> * Reuse iommufd_backend_get_device_info() for capabilities (Zhenzhong) >>> * New patches 1 and 2 taking into consideration previous comments. >>> * Store hwpt::flags to know if we have dirty tracking (Avihai) >>> * New patch 8, that allows to query dirty tracking support after >>> provisioning. This is a cleaner way to check IOMMU dirty tracking support >>> when vfio::migration is iniitalized, as opposed to RFCv2 via device caps. >>> device caps way is still used because at vfio attach we aren't yet with >>> a fully initialized migration state. >>> * Adopt error propagation in query,set dirty tracking >>> * Misc improvements overall broadly and Avihai >>> * Drop hugepages as it's a bit unrelated; I can pursue that patch >>> * separately. The main motivation is to provide a way to test >>> without hugepages similar to what vfio_type1_iommu.disable_hugepages=1 >>> does. >>> >>> Changes since RFCv1[2]: >>> * Remove intel/amd dirty tracking emulation enabling >>> * Remove the dirtyrate improvement for VF/IOMMU dirty tracking >>> [Will pursue these two in separate series] >>> * Introduce auto domains support >>> * Enforce dirty tracking following the IOMMUFD UAPI for this >>> * Add support for toggling hugepages in IOMMUFD >>> * Auto enable support when VF supports migration to use IOMMU >>> when it doesn't have VF dirty tracking >>> * Add a parameter to toggle VF dirty tracking >>> >>> [0] >>> https://lore.kernel.org/qemu-devel/20240201072818.327930-1-zhenzhong.duan@intel.com/ >>> [1] >>> https://lore.kernel.org/qemu-devel/20240201072818.327930-10-zhenzhong.duan@intel.com/ >>> [2] >>> https://lore.kernel.org/qemu-devel/20220428211351.3897-1-joao.m.martins@oracle.com/ >>> [3] >>> https://lore.kernel.org/qemu-devel/20230622214845.3980-1-joao.m.martins@oracle.com/ >>> [4] >>> https://lore.kernel.org/qemu-devel/20240212135643.5858-1-joao.m.martins@oracle.com/ >>> [5] >>> https://lore.kernel.org/qemu-devel/20240708143420.16953-1-joao.m.martins@oracle.com/ >>> [6] >>> https://lore.kernel.org/qemu-devel/20240719120501.81279-1-joao.m.martins@oracle.com/ >>> >>> Joao Martins (9): >>>    vfio/iommufd: Introduce auto domain creation >>>    vfio/{iommufd,container}: Remove caps::aw_bits >>>    vfio/iommufd: Add hw_caps field to HostIOMMUDeviceCaps >>>    vfio/{iommufd,container}: Invoke HostIOMMUDevice::realize() during >>>      attach_device() >>>    vfio/iommufd: Probe and request hwpt dirty tracking capability >>>    vfio/iommufd: Implement VFIOIOMMUClass::set_dirty_tracking support >>>    vfio/iommufd: Implement VFIOIOMMUClass::query_dirty_bitmap support >>>    vfio/migration: Don't block migration device dirty tracking is >>>      unsupported >>>    vfio/common: Allow disabling device dirty page tracking >>> >>>   include/hw/vfio/vfio-common.h      |  13 +++ >>>   include/sysemu/host_iommu_device.h |   5 +- >>>   include/sysemu/iommufd.h           |  11 ++ >>>   backends/iommufd.c                 |  85 ++++++++++++++- >>>   hw/vfio/common.c                   |  19 ++-- >>>   hw/vfio/container.c                |   9 +- >>>   hw/vfio/helpers.c                  |  11 ++ >>>   hw/vfio/iommufd.c                  | 170 ++++++++++++++++++++++++++++- >>>   hw/vfio/migration.c                |  12 +- >>>   hw/vfio/pci.c                      |   3 + >>>   backends/trace-events              |   3 + >>>   11 files changed, 318 insertions(+), 23 deletions(-) >> >> Applied to vfio-next with the changes that were discussed this morning. >> Please check. >> > > I think the only thing missing is in the fourth patch to add the comment Eric > suggested (see below). Other than that, looks good to me. > > diff --git a/hw/vfio/iommufd.c b/hw/vfio/iommufd.c > index 50ffa4b77090..abb6f1a4b4a8 100644 > --- a/hw/vfio/iommufd.c > +++ b/hw/vfio/iommufd.c > @@ -488,6 +488,13 @@ static bool iommufd_cdev_attach(const char *name, > VFIODevice *vbasedev, > > space = vfio_get_address_space(as); > > + /* > + * The HostIOMMUDevice data from legacy backend is static and doesn't need > + * any information from the (type1-iommu) backend to be initialized. In > + * contrast however, the IOMMUFD HostIOMMUDevice data requires the iommufd > + * FD to be connected and having a devid to be able to successfully call > + * iommufd_backend_get_device_info(). > + */ > if (!vfio_device_hiod_realize(vbasedev, errp)) { > goto err_alloc_ioas; > } > Yep. This is fixed now. I will send a vfio PR in a couple of hours. Thanks, C.