From: David Hildenbrand <david@redhat.com>
To: "Akihiko Odaki" <akihiko.odaki@daynix.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] system/physmem: Fix reference to dump-guest-core
Date: Mon, 1 Jul 2024 18:06:39 +0200 [thread overview]
Message-ID: <567005b5-2805-44db-a455-587566f6bd8f@redhat.com> (raw)
In-Reply-To: <20240628-dump-v1-1-c581d10f3646@daynix.com>
On 28.06.24 06:05, Akihiko Odaki wrote:
> dump_guest_core is exposed as dump-guest-core with QOM.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> system/physmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/system/physmem.c b/system/physmem.c
> index b7847db1a2c5..effa97184f25 100644
> --- a/system/physmem.c
> +++ b/system/physmem.c
> @@ -1521,7 +1521,7 @@ static void qemu_ram_setup_dump(void *addr, ram_addr_t size)
> if (ret) {
> perror("qemu_madvise");
> fprintf(stderr, "madvise doesn't support MADV_DONTDUMP, "
> - "but dump_guest_core=off specified\n");
> + "but dump-guest-core=off specified\n");
> }
> }
> }
>
> ---
> base-commit: 046a64b9801343e2e89eef10c7a48eec8d8c0d4f
> change-id: 20240614-dump-7b73ab18c31a
>
> Best regards,
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2024-07-01 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 4:05 [PATCH] system/physmem: Fix reference to dump-guest-core Akihiko Odaki
2024-06-28 4:58 ` Philippe Mathieu-Daudé
2024-07-01 14:59 ` Philippe Mathieu-Daudé
2024-07-01 16:06 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567005b5-2805-44db-a455-587566f6bd8f@redhat.com \
--to=david@redhat.com \
--cc=akihiko.odaki@daynix.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).