* [PATCH] system/physmem: Fix reference to dump-guest-core
@ 2024-06-28 4:05 Akihiko Odaki
2024-06-28 4:58 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Akihiko Odaki @ 2024-06-28 4:05 UTC (permalink / raw)
To: Paolo Bonzini, Peter Xu, David Hildenbrand,
Philippe Mathieu-Daudé
Cc: qemu-devel, Akihiko Odaki
dump_guest_core is exposed as dump-guest-core with QOM.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
system/physmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/system/physmem.c b/system/physmem.c
index b7847db1a2c5..effa97184f25 100644
--- a/system/physmem.c
+++ b/system/physmem.c
@@ -1521,7 +1521,7 @@ static void qemu_ram_setup_dump(void *addr, ram_addr_t size)
if (ret) {
perror("qemu_madvise");
fprintf(stderr, "madvise doesn't support MADV_DONTDUMP, "
- "but dump_guest_core=off specified\n");
+ "but dump-guest-core=off specified\n");
}
}
}
---
base-commit: 046a64b9801343e2e89eef10c7a48eec8d8c0d4f
change-id: 20240614-dump-7b73ab18c31a
Best regards,
--
Akihiko Odaki <akihiko.odaki@daynix.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] system/physmem: Fix reference to dump-guest-core
2024-06-28 4:05 [PATCH] system/physmem: Fix reference to dump-guest-core Akihiko Odaki
@ 2024-06-28 4:58 ` Philippe Mathieu-Daudé
2024-07-01 14:59 ` Philippe Mathieu-Daudé
2024-07-01 16:06 ` David Hildenbrand
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-06-28 4:58 UTC (permalink / raw)
To: Akihiko Odaki, Paolo Bonzini, Peter Xu, David Hildenbrand; +Cc: qemu-devel
On 28/6/24 06:05, Akihiko Odaki wrote:
> dump_guest_core is exposed as dump-guest-core with QOM.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> system/physmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] system/physmem: Fix reference to dump-guest-core
2024-06-28 4:05 [PATCH] system/physmem: Fix reference to dump-guest-core Akihiko Odaki
2024-06-28 4:58 ` Philippe Mathieu-Daudé
@ 2024-07-01 14:59 ` Philippe Mathieu-Daudé
2024-07-01 16:06 ` David Hildenbrand
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-07-01 14:59 UTC (permalink / raw)
To: Akihiko Odaki, Paolo Bonzini, Peter Xu, David Hildenbrand; +Cc: qemu-devel
On 28/6/24 06:05, Akihiko Odaki wrote:
> dump_guest_core is exposed as dump-guest-core with QOM.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> system/physmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch queued.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] system/physmem: Fix reference to dump-guest-core
2024-06-28 4:05 [PATCH] system/physmem: Fix reference to dump-guest-core Akihiko Odaki
2024-06-28 4:58 ` Philippe Mathieu-Daudé
2024-07-01 14:59 ` Philippe Mathieu-Daudé
@ 2024-07-01 16:06 ` David Hildenbrand
2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2024-07-01 16:06 UTC (permalink / raw)
To: Akihiko Odaki, Paolo Bonzini, Peter Xu,
Philippe Mathieu-Daudé
Cc: qemu-devel
On 28.06.24 06:05, Akihiko Odaki wrote:
> dump_guest_core is exposed as dump-guest-core with QOM.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> system/physmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/system/physmem.c b/system/physmem.c
> index b7847db1a2c5..effa97184f25 100644
> --- a/system/physmem.c
> +++ b/system/physmem.c
> @@ -1521,7 +1521,7 @@ static void qemu_ram_setup_dump(void *addr, ram_addr_t size)
> if (ret) {
> perror("qemu_madvise");
> fprintf(stderr, "madvise doesn't support MADV_DONTDUMP, "
> - "but dump_guest_core=off specified\n");
> + "but dump-guest-core=off specified\n");
> }
> }
> }
>
> ---
> base-commit: 046a64b9801343e2e89eef10c7a48eec8d8c0d4f
> change-id: 20240614-dump-7b73ab18c31a
>
> Best regards,
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-01 16:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-28 4:05 [PATCH] system/physmem: Fix reference to dump-guest-core Akihiko Odaki
2024-06-28 4:58 ` Philippe Mathieu-Daudé
2024-07-01 14:59 ` Philippe Mathieu-Daudé
2024-07-01 16:06 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).