From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40674)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1a8pJQ-0007No-Sz
	for qemu-devel@nongnu.org; Tue, 15 Dec 2015 08:06:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1a8pJL-00028K-4T
	for qemu-devel@nongnu.org; Tue, 15 Dec 2015 08:06:40 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54662)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1a8pJK-000283-VT
	for qemu-devel@nongnu.org; Tue, 15 Dec 2015 08:06:35 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (Postfix) with ESMTPS id 0D44FB0F9F
	for <qemu-devel@nongnu.org>; Tue, 15 Dec 2015 13:06:34 +0000 (UTC)
References: <1449859353-1574-1-git-send-email-ehabkost@redhat.com>
	<1449859353-1574-9-git-send-email-ehabkost@redhat.com>
From: Marcel Apfelbaum <marcel@redhat.com>
Message-ID: <56701057.2020905@redhat.com>
Date: Tue, 15 Dec 2015 15:06:31 +0200
MIME-Version: 1.0
In-Reply-To: <1449859353-1574-9-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 08/14] acpi: Don't save PcGuestInfo on
	AcpiBuildState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>, Marcel Apfelbaum <marcel.a@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

On 12/11/2015 08:42 PM, Eduardo Habkost wrote:
> We don't need to save the pointer on AcpiBuildState, as it is not
> used anymore.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>   hw/i386/acpi-build.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 92d25c9..82d55bb 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -1648,7 +1648,6 @@ struct AcpiBuildState {
>       MemoryRegion *table_mr;
>       /* Is table patched? */
>       uint8_t patched;
> -    PcGuestInfo *guest_info;
>       void *rsdp;
>       MemoryRegion *rsdp_mr;
>       MemoryRegion *linker_mr;
> @@ -1922,8 +1921,6 @@ void acpi_setup(void)
>
>       build_state = g_malloc0(sizeof *build_state);
>
> -    build_state->guest_info = guest_info;
> -
>       acpi_set_pci_info();
>
>       acpi_build_tables_init(&tables);
>

Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>