From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8rN4-0006HB-TL for qemu-devel@nongnu.org; Tue, 15 Dec 2015 10:18:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8rMz-0002RL-UV for qemu-devel@nongnu.org; Tue, 15 Dec 2015 10:18:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38061) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8rMz-0002PB-P7 for qemu-devel@nongnu.org; Tue, 15 Dec 2015 10:18:29 -0500 References: <1450082498-27109-1-git-send-email-a.rigo@virtualopensystems.com> <1450082498-27109-7-git-send-email-a.rigo@virtualopensystems.com> <566E9685.4030606@redhat.com> <56702428.9040603@redhat.com> From: Laurent Vivier Message-ID: <56702F40.9050101@redhat.com> Date: Tue, 15 Dec 2015 16:18:24 +0100 MIME-Version: 1.0 In-Reply-To: <56702428.9040603@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v6 06/14] configure: Use slow-path for atomic only when the softmmu is enabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , alvise rigo Cc: mttcg@greensocs.com, Claudio Fontana , QEMU Developers , Jani Kokkonen , VirtualOpenSystems Technical Team , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Richard Henderson On 15/12/2015 15:31, Paolo Bonzini wrote: > > > On 15/12/2015 15:23, alvise rigo wrote: >> Hi, >> >> On Mon, Dec 14, 2015 at 11:14 AM, Laurent Vivier wrote: >>> >>> >>> On 14/12/2015 09:41, Alvise Rigo wrote: >>>> Use the new slow path for atomic instruction translation when the >>>> softmmu is enabled. >>>> >>>> Suggested-by: Jani Kokkonen >>>> Suggested-by: Claudio Fontana >>>> Signed-off-by: Alvise Rigo >>>> --- >>>> configure | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/configure b/configure >>>> index b9552fd..cc3891a 100755 >>>> --- a/configure >>>> +++ b/configure >>>> @@ -4794,6 +4794,7 @@ echo "Install blobs $blobs" >>>> echo "KVM support $kvm" >>>> echo "RDMA support $rdma" >>>> echo "TCG interpreter $tcg_interpreter" >>>> +echo "use ld/st excl $softmmu" >>>> echo "fdt support $fdt" >>>> echo "preadv support $preadv" >>>> echo "fdatasync $fdatasync" >>>> @@ -5186,6 +5187,9 @@ fi >>>> if test "$tcg_interpreter" = "yes" ; then >>>> echo "CONFIG_TCG_INTERPRETER=y" >> $config_host_mak >>>> fi >>>> +if test "$softmmu" = "yes" ; then >>>> + echo "CONFIG_TCG_USE_LDST_EXCL=y" >> $config_host_mak >>>> +fi >>> >>> why is this "$softmmu" and not "$target_softmmu" ? >> >> I see now that is $target_softmmu setting CONFIG_SOFTMMU=y. >> So for my understanding, which are the cases where $softmmu is set >> while $target_softmmu is not? > > When compiling foo-linux-user. In fact, after having asked the question, I've found that it is right to use softmmu which is a host parameter (while target_softmmu is guest parameter) and softmmu is set to true if there is at least one *-softmmu target. Laurent