qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options
@ 2015-12-15 11:46 Thomas Huth
  2015-12-15 12:51 ` Paolo Bonzini
  0 siblings, 1 reply; 14+ messages in thread
From: Thomas Huth @ 2015-12-15 11:46 UTC (permalink / raw)
  To: qemu-devel, Jason Wang

We likely don't want to maintain the legacy -net options forever,
so let's start informing the users that this option will be
removed in a future version. However, there are two cases where
we should not spill out a message yet: First is the "-net nic"
option which might still be required to configure on-board NICs
that can not be handled via "-netdev" yet, and second is the
"-net user" default option that is created automatically when
no other networking option has been specified.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 net/net.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/net/net.c b/net/net.c
index ade6051..2593961 100644
--- a/net/net.c
+++ b/net/net.c
@@ -1006,6 +1006,12 @@ static int net_client_init1(const void *object, int is_netdev, Error **errp)
             return -1;
         }
 
+        if (opts->type != NET_CLIENT_OPTIONS_KIND_NIC &&
+            (!default_net || opts->type != NET_CLIENT_OPTIONS_KIND_USER)) {
+            error_report("Deprecated net option - "
+                         "this will be removed in a future version!");
+        }
+
         if (!net_client_init_fun[opts->type]) {
             error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "type",
                        "a net backend type (maybe it is not compiled "
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2015-12-16  8:50 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-15 11:46 [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options Thomas Huth
2015-12-15 12:51 ` Paolo Bonzini
2015-12-15 16:01   ` Thomas Huth
2015-12-15 16:21     ` Paolo Bonzini
2015-12-15 16:46       ` Eric Blake
2015-12-15 17:15       ` Thomas Huth
2015-12-15 17:31         ` Paolo Bonzini
2015-12-15 17:50           ` Thomas Huth
2015-12-15 18:08             ` Paolo Bonzini
2015-12-16  7:20               ` Thomas Huth
2015-12-16  8:50                 ` Paolo Bonzini
2015-12-15 16:17   ` Peter Maydell
2015-12-15 16:33     ` Thomas Huth
2015-12-15 16:46       ` Peter Maydell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).