From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8tkG-0008IS-8X for qemu-devel@nongnu.org; Tue, 15 Dec 2015 12:50:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8tkB-00041o-6Q for qemu-devel@nongnu.org; Tue, 15 Dec 2015 12:50:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8tkB-00041g-1V for qemu-devel@nongnu.org; Tue, 15 Dec 2015 12:50:35 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 6BE658E221 for ; Tue, 15 Dec 2015 17:50:34 +0000 (UTC) References: <1450179992-15959-1-git-send-email-thuth@redhat.com> <56700CBA.5010505@redhat.com> <56703969.9050905@redhat.com> <56703E09.5000504@redhat.com> <56704ACB.8010909@redhat.com> <56704E82.3080403@redhat.com> From: Thomas Huth Message-ID: <567052E7.3000903@redhat.com> Date: Tue, 15 Dec 2015 18:50:31 +0100 MIME-Version: 1.0 In-Reply-To: <56704E82.3080403@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org, Jason Wang Cc: Markus Armbruster On 15/12/15 18:31, Paolo Bonzini wrote: >=20 > On 15/12/2015 18:15, Thomas Huth wrote: >> On 15/12/15 17:21, Paolo Bonzini wrote: [...] >>> For example you could print all DEVICE_CATEGORY_NETWORK devices that >>> support device_add. >> >> I think that would not work since spapr-vlan is not hot-pluggable. >=20 > cannot_instantiate_with_device_add_yet which actually refers to -device= , > not really device_add, so it would work. I just tried: (qemu) device_add spapr-vlan Bus 'spapr-vio' does not support hotplugging ... did I miss something? >>> The thing is, people are still running QEMU from the command line. >>> >>> "-net nic -net bridge,br=3Dvirbr0" is still much less of a mouthful t= han >>> "-netdev bridge,br=3Dvirbr0,id=3Dbr -device rtl8139,netdev=3Dbr" if a= ll I want >>> is something I can ssh into. >>> >>> It's easy to deprecate things. It's hard to convince users that it's >>> worth, and you haven't convinced this user. :) >> >> Ok, if you want to maintain that legacy stuff forever - fine. >=20 > I don't want to, but I think we have to. It would be a good idea to ge= t > rid of it, but unfortunately it's not a feasible idea IMHO. If the code gets unmaintainable because there is too much legacy cruft in it, that's IMHO even worse. At one point in time, you just have to get rid of such stuff ... but well, maybe the time for the "-net" option just has not come yet. Thomas