From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8u1Q-0007Jp-Ft for qemu-devel@nongnu.org; Tue, 15 Dec 2015 13:08:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8u1M-0001AY-Fr for qemu-devel@nongnu.org; Tue, 15 Dec 2015 13:08:24 -0500 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:34999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8u1M-0001AS-9T for qemu-devel@nongnu.org; Tue, 15 Dec 2015 13:08:20 -0500 Received: by mail-wm0-x235.google.com with SMTP id l126so5765908wml.0 for ; Tue, 15 Dec 2015 10:08:20 -0800 (PST) Sender: Paolo Bonzini References: <1450179992-15959-1-git-send-email-thuth@redhat.com> <56700CBA.5010505@redhat.com> <56703969.9050905@redhat.com> <56703E09.5000504@redhat.com> <56704ACB.8010909@redhat.com> <56704E82.3080403@redhat.com> <567052E7.3000903@redhat.com> From: Paolo Bonzini Message-ID: <56705711.1000702@redhat.com> Date: Tue, 15 Dec 2015 19:08:17 +0100 MIME-Version: 1.0 In-Reply-To: <567052E7.3000903@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org, Jason Wang Cc: Markus Armbruster On 15/12/2015 18:50, Thomas Huth wrote: > On 15/12/15 18:31, Paolo Bonzini wrote: >> >> On 15/12/2015 18:15, Thomas Huth wrote: >>> On 15/12/15 17:21, Paolo Bonzini wrote: > [...] >>>> For example you could print all DEVICE_CATEGORY_NETWORK devices that >>>> support device_add. >>> >>> I think that would not work since spapr-vlan is not hot-pluggable. >> >> cannot_instantiate_with_device_add_yet which actually refers to -device, >> not really device_add, so it would work. > > I just tried: > > (qemu) device_add spapr-vlan > Bus 'spapr-vio' does not support hotplugging > > ... did I miss something? When I said "support device_add" I really meant "does not have cannot_instantiate_with_device_add_yet", but spapr-vlan should pass that test. >>>> The thing is, people are still running QEMU from the command line. >>>> >>>> "-net nic -net bridge,br=virbr0" is still much less of a mouthful than >>>> "-netdev bridge,br=virbr0,id=br -device rtl8139,netdev=br" if all I want >>>> is something I can ssh into. >>>> >>>> It's easy to deprecate things. It's hard to convince users that it's >>>> worth, and you haven't convinced this user. :) >>> >>> Ok, if you want to maintain that legacy stuff forever - fine. >> >> I don't want to, but I think we have to. It would be a good idea to get >> rid of it, but unfortunately it's not a feasible idea IMHO. > > If the code gets unmaintainable because there is too much legacy cruft > in it, that's IMHO even worse. At one point in time, you just have to > get rid of such stuff ... but well, maybe the time for the "-net" option > just has not come yet. Yes, indeed. I don't think it's unmaintainable. It used to be much worse, and it could be improved. Paolo