From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a93uM-0004Gr-KS for qemu-devel@nongnu.org; Tue, 15 Dec 2015 23:41:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a93uL-0004Md-Lr for qemu-devel@nongnu.org; Tue, 15 Dec 2015 23:41:46 -0500 References: <1450150404-20668-1-git-send-email-lszhu@suse.com> <567075F8.5090201@redhat.com> From: Zhu Lingshan Message-ID: <5670EB74.8040808@suse.com> Date: Wed, 16 Dec 2015 12:41:24 +0800 MIME-Version: 1.0 In-Reply-To: <567075F8.5090201@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] iscsi: fix readcapacity error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: QEMU Trivial , pbonzini@redhat.com, pl@kamp.de, qemu-devel@nongnu.org, ronniesahlberg@gmail.com OK, thanks, I have sent the patch again and CC them On 12/16/2015 04:20 AM, John Snow wrote: > CC qemu-trivial, I think this can go in through that tree. > > On 12/14/2015 10:33 PM, Zhu Lingshan wrote: >> fix:The error message for readcapacity 16 incorrectly mentioned >> a readcapacity 10 failure, fixed the error message. >> >> Signed-off-by: Zhu Lingshan >> --- >> block/iscsi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/block/iscsi.c b/block/iscsi.c >> index bd1f1bf..eb28ddc 100644 >> --- a/block/iscsi.c >> +++ b/block/iscsi.c >> @@ -1270,7 +1270,7 @@ static void iscsi_readcapacity_sync(IscsiLun *iscsilun, Error **errp) >> && retries-- > 0); >> >> if (task == NULL || task->status != SCSI_STATUS_GOOD) { >> - error_setg(errp, "iSCSI: failed to send readcapacity10 command."); >> + error_setg(errp, "iSCSI: failed to send readcapacity10/16 command"); >> } else if (!iscsilun->block_size || >> iscsilun->block_size % BDRV_SECTOR_SIZE) { >> error_setg(errp, "iSCSI: the target returned an invalid " >> > Reviewed-by: John Snow >