From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a96OR-0007wx-Jo for qemu-devel@nongnu.org; Wed, 16 Dec 2015 02:21:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a96OO-0006Cj-DE for qemu-devel@nongnu.org; Wed, 16 Dec 2015 02:20:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a96OO-0006Cf-7i for qemu-devel@nongnu.org; Wed, 16 Dec 2015 02:20:56 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id A3EEF8F50A for ; Wed, 16 Dec 2015 07:20:55 +0000 (UTC) References: <1450179992-15959-1-git-send-email-thuth@redhat.com> <56700CBA.5010505@redhat.com> <56703969.9050905@redhat.com> <56703E09.5000504@redhat.com> <56704ACB.8010909@redhat.com> <56704E82.3080403@redhat.com> <567052E7.3000903@redhat.com> <56705711.1000702@redhat.com> From: Thomas Huth Message-ID: <567110D4.1040205@redhat.com> Date: Wed, 16 Dec 2015 08:20:52 +0100 MIME-Version: 1.0 In-Reply-To: <56705711.1000702@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org, Jason Wang Cc: Markus Armbruster On 15/12/15 19:08, Paolo Bonzini wrote: >=20 >=20 > On 15/12/2015 18:50, Thomas Huth wrote: >> On 15/12/15 18:31, Paolo Bonzini wrote: >>> >>> On 15/12/2015 18:15, Thomas Huth wrote: >>>> On 15/12/15 17:21, Paolo Bonzini wrote: >> [...] >>>>> For example you could print all DEVICE_CATEGORY_NETWORK devices tha= t >>>>> support device_add. >>>> >>>> I think that would not work since spapr-vlan is not hot-pluggable. >>> >>> cannot_instantiate_with_device_add_yet which actually refers to -devi= ce, >>> not really device_add, so it would work. >> >> I just tried: >> >> (qemu) device_add spapr-vlan >> Bus 'spapr-vio' does not support hotplugging >> >> ... did I miss something? >=20 > When I said "support device_add" I really meant "does not have > cannot_instantiate_with_device_add_yet", but spapr-vlan should pass tha= t > test. Ah, ok, that makes more sense... anyway, "-device ?" also lists some devices like "ne2k_isa", ""usb-bt-dongle" and "vmxnet3" ... I somewhat doubt that we want to have these in the list of "-net nic" supported devices, too. ... hmmm, by the way, why the heck do we have vmxnet3 on powerpc? Does that make sense at all? >>>>> The thing is, people are still running QEMU from the command line. >>>>> >>>>> "-net nic -net bridge,br=3Dvirbr0" is still much less of a mouthful= than >>>>> "-netdev bridge,br=3Dvirbr0,id=3Dbr -device rtl8139,netdev=3Dbr" if= all I want >>>>> is something I can ssh into. >>>>> >>>>> It's easy to deprecate things. It's hard to convince users that it= 's >>>>> worth, and you haven't convinced this user. :) Just another idea before we drop this topic again completely: What if we'd extend "-netdev" to be easier to use, too. For example, if you'd just specify "-netdev bridge,br=3Dvirbr0", without using an id and withou= t specifying a "-device", you would get the netdev hooked up to the board's default NIC automatically. That would be even less to type than your example with "-net" since you would not need the "-net nic" parameter in that case... Would it then be ok to deprecate the "-net" option? Thomas