From: Paolo Bonzini <pbonzini@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: qemu-devel@nongnu.org, Dmitry Andreev <dandreev@virtuozzo.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] qmp: process system-reset event in paused state
Date: Wed, 16 Dec 2015 10:12:20 +0100 [thread overview]
Message-ID: <56712AF4.9030105@redhat.com> (raw)
In-Reply-To: <1450256449-23779-1-git-send-email-den@openvz.org>
On 16/12/2015 10:00, Denis V. Lunev wrote:
> With pvpanic or HyperV panic devices could be moved into the paused state
> with ' <on_crash>preserve</on_crash>'. In this state VM reacts only to
> 'virsh destroy' or 'continue'.
>
> 'virsh reset' command is usually used to force guest reset. The expectation
> of the behavior of this command is that the guest will be force restarted.
> This is not true at the moment.
Does "virsh reset" + "virsh continue" work, and if not why?
> Thus it is quite natural to process 'virh reset' aka qmp_system_reset
> this way, i.e. allow to reset the guest. This behavior is similar to
> one observed with 'reset' button on real hardware :)
Paolo
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Markus Armbruster <armbru@redhat.com>
> CC: Dmitry Andreev <dandreev@virtuozzo.com>
> ---
> qmp.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/qmp.c b/qmp.c
> index 0a1fa19..df17a33 100644
> --- a/qmp.c
> +++ b/qmp.c
> @@ -112,6 +112,10 @@ void qmp_stop(Error **errp)
> void qmp_system_reset(Error **errp)
> {
> qemu_system_reset_request();
> +
> + if (!runstate_is_running()) {
> + vm_start();
> + }
> }
>
> void qmp_system_powerdown(Error **erp)
>
next prev parent reply other threads:[~2015-12-16 9:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 9:00 [Qemu-devel] [PATCH 1/1] qmp: process system-reset event in paused state Denis V. Lunev
2015-12-16 9:12 ` Paolo Bonzini [this message]
2015-12-16 9:32 ` Denis V. Lunev
2015-12-16 9:35 ` Paolo Bonzini
2015-12-16 9:50 ` Denis V. Lunev
2015-12-16 9:37 ` Peter Krempa
2015-12-16 9:50 ` Peter Krempa
2015-12-16 9:55 ` Denis V. Lunev
2015-12-16 12:02 ` Paolo Bonzini
2015-12-16 14:47 ` Denis V. Lunev
2016-01-11 10:31 ` Denis V. Lunev
2016-01-11 11:29 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56712AF4.9030105@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=dandreev@virtuozzo.com \
--cc=den@openvz.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).