From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56007)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1a98ix-0004rd-3W
	for qemu-devel@nongnu.org; Wed, 16 Dec 2015 04:50:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1a98iq-0004kt-Im
	for qemu-devel@nongnu.org; Wed, 16 Dec 2015 04:50:19 -0500
Received: from mx2.parallels.com ([199.115.105.18]:36544)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1a98iq-0004kn-Ci
	for qemu-devel@nongnu.org; Wed, 16 Dec 2015 04:50:12 -0500
References: <1450256449-23779-1-git-send-email-den@openvz.org>
	<56712AF4.9030105@redhat.com> <56712F9D.4000406@openvz.org>
	<5671304F.3020902@redhat.com>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <567133CA.7030603@openvz.org>
Date: Wed, 16 Dec 2015 12:50:02 +0300
MIME-Version: 1.0
In-Reply-To: <5671304F.3020902@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/1] qmp: process system-reset event in
	paused state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Dmitry Andreev <dandreev@virtuozzo.com>, Markus Armbruster <armbru@redhat.com>

On 12/16/2015 12:35 PM, Paolo Bonzini wrote:
>
> On 16/12/2015 10:32, Denis V. Lunev wrote:
>>>>
>>>> 'virsh reset' command is usually used to force guest reset. The
>>>> expectation
>>>> of the behavior of this command is that the guest will be force
>>>> restarted.
>>>> This is not true at the moment.
>>> Does "virsh reset" + "virsh continue" work, and if not why?
>> as far as I can see there is no such command in virsh at all :(
> Right, it's "virsh resume". :)
>
> Paolo

actually it does not.

'virsh resume' does not emit command to trigger qmp_cont
in this state. With manual 'virsh qemu-monitor event {"execute": "cont"}'
it starts to work.

Do you propose to kludge libvirt and send 'continue' unconditionally
before a 'reset'? We can but there is not much sense not to implement
this is libvirt due to 'unconditionality'...

Sending command in 'crashed' state only is a bit racy. The event
moving domain into 'crashed' state could be not processed at
the moment.

Den