From: Eric Blake <eblake@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: zhang.zhanghailiang@huawei.com, quintela@redhat.com,
liang.z.li@intel.com, qemu-devel@nongnu.org,
amit.shah@redhat.com, jdenemar@redhat.com
Subject: Re: [Qemu-devel] [PATCH 4/6] Migration: Emit event at start of pass
Date: Wed, 16 Dec 2015 09:40:18 -0700 [thread overview]
Message-ID: <567193F2.6060006@redhat.com> (raw)
In-Reply-To: <20151216100142.GA2604@work-vm>
[-- Attachment #1: Type: text/plain, Size: 762 bytes --]
On 12/16/2015 03:01 AM, Dr. David Alan Gilbert wrote:
>> Missing documentation of the 'pass' member - is it a counter that says
>> which pass this event is, incrementing each time through?
>
> Thanks; yes, I added the pass parameter afterwards; I'll add:
>
> # @pass: An incrementing count (starting at 1 on the first pass)
>
>> Also missing docs in events.txt (although that file may go away soon,
>> once we get Marc-Andre's patches in for automating documentation from
>> .json files).
>
> OK, I'll add the following (docs/qmp-events.txt):
Ah, you figured out the file I really meant. Your additions look
reasonable for v2.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-12-16 16:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 19:02 [Qemu-devel] [PATCH 0/6] Migration: Small fixes and improvements Dr. David Alan Gilbert (git)
2015-12-15 19:02 ` [Qemu-devel] [PATCH 1/6] migration: Export migrate_set_state() Dr. David Alan Gilbert (git)
2015-12-16 10:25 ` Juan Quintela
2015-12-15 19:02 ` [Qemu-devel] [PATCH 2/6] migration: Add state records for migration incoming Dr. David Alan Gilbert (git)
2015-12-16 10:26 ` Juan Quintela
2015-12-15 19:02 ` [Qemu-devel] [PATCH 3/6] Postcopy: Send events/change state on incoming side Dr. David Alan Gilbert (git)
2015-12-16 5:10 ` Hailiang Zhang
2015-12-16 10:27 ` Juan Quintela
2015-12-15 19:02 ` [Qemu-devel] [PATCH 4/6] Migration: Emit event at start of pass Dr. David Alan Gilbert (git)
2015-12-15 21:07 ` Eric Blake
2015-12-16 10:01 ` Dr. David Alan Gilbert
2015-12-16 16:40 ` Eric Blake [this message]
2015-12-16 10:29 ` Juan Quintela
2015-12-15 19:02 ` [Qemu-devel] [PATCH 5/6] Use qemu_get_buffer_in_place for xbzrle data Dr. David Alan Gilbert (git)
2015-12-16 10:37 ` Juan Quintela
2015-12-15 19:02 ` [Qemu-devel] [PATCH 6/6] multithread decompression: Avoid one copy Dr. David Alan Gilbert (git)
2015-12-16 1:12 ` Li, Liang Z
2015-12-16 10:35 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567193F2.6060006@redhat.com \
--to=eblake@redhat.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jdenemar@redhat.com \
--cc=liang.z.li@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).