From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9F7o-0001qd-Ad for qemu-devel@nongnu.org; Wed, 16 Dec 2015 11:40:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9F7l-0002Ua-FL for qemu-devel@nongnu.org; Wed, 16 Dec 2015 11:40:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9F7l-0002UU-9O for qemu-devel@nongnu.org; Wed, 16 Dec 2015 11:40:21 -0500 References: <1450206170-26901-1-git-send-email-dgilbert@redhat.com> <1450206170-26901-5-git-send-email-dgilbert@redhat.com> <56708105.2050508@redhat.com> <20151216100142.GA2604@work-vm> From: Eric Blake Message-ID: <567193F2.6060006@redhat.com> Date: Wed, 16 Dec 2015 09:40:18 -0700 MIME-Version: 1.0 In-Reply-To: <20151216100142.GA2604@work-vm> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nSDp82uPpoAocplRrDXlkpqD2ANCoXkn6" Subject: Re: [Qemu-devel] [PATCH 4/6] Migration: Emit event at start of pass List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: zhang.zhanghailiang@huawei.com, quintela@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, amit.shah@redhat.com, jdenemar@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nSDp82uPpoAocplRrDXlkpqD2ANCoXkn6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/16/2015 03:01 AM, Dr. David Alan Gilbert wrote: >> Missing documentation of the 'pass' member - is it a counter that says= >> which pass this event is, incrementing each time through? >=20 > Thanks; yes, I added the pass parameter afterwards; I'll add: >=20 > # @pass: An incrementing count (starting at 1 on the first pass) >=20 >> Also missing docs in events.txt (although that file may go away soon, >> once we get Marc-Andre's patches in for automating documentation from >> .json files). >=20 > OK, I'll add the following (docs/qmp-events.txt): Ah, you figured out the file I really meant. Your additions look reasonable for v2. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nSDp82uPpoAocplRrDXlkpqD2ANCoXkn6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWcZPyAAoJEKeha0olJ0Nqw5cH/2UyFKDJWbZ8Yx8qacdgu42r dUkHN/wFdxTbd8TSdgVs3triXb4AyFyEM4nPQZkgfxMZD8Uyj7xKdV6lvxN60Bhm 8HTIyBjVMmFnnLF4Nh1r4vJUcBmUuYO1xvO6xKpbjaMbGYevQRklZ8OZc1fM0ezx QeTyIxahZJ0Si2MOH/8T27VCJF9KigMz7F0BQ4A+jRsEFl0QkOK2rU1eKhLPcbKg AIRRiXUDN767gE0z6xAy5ghULKaKhd/gwRNyi82/247TwktvnezbLguD5306juws j9CjvJNzL1D9OXvfHwlSVRBmzrVlj0SR11S0ejKe1s5kLnfSaGIRuOQtp6edbVM= =7DLB -----END PGP SIGNATURE----- --nSDp82uPpoAocplRrDXlkpqD2ANCoXkn6--