From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9L6T-0002Da-Ft for qemu-devel@nongnu.org; Wed, 16 Dec 2015 18:03:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9L6S-0001eK-Jm for qemu-devel@nongnu.org; Wed, 16 Dec 2015 18:03:25 -0500 References: <1450304177-3935-1-git-send-email-jsnow@redhat.com> <1450304177-3935-5-git-send-email-jsnow@redhat.com> From: Eric Blake Message-ID: <5671EDB0.9070901@redhat.com> Date: Wed, 16 Dec 2015 16:03:12 -0700 MIME-Version: 1.0 In-Reply-To: <1450304177-3935-5-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MujV8P3aPL3BQB4XfS04fFmkJpPPlqG3K" Subject: Re: [Qemu-devel] [PATCH v3 04/11] fdc: add default drive type option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MujV8P3aPL3BQB4XfS04fFmkJpPPlqG3K Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/16/2015 03:16 PM, John Snow wrote: > This patch adds a new explicit Floppy Drive Type option. The existing > behavior in QEMU is to automatically guess a drive type based on the > media inserted, or if a diskette is not present, arbitrarily assign one= =2E >=20 > This behavior can be described as "auto." This patch adds explicit > behaviors: 120, 144, 288, auto, and none. The new "auto" behavior > is intended to mimick current behavior, while the other types pick > one explicitly. >=20 > In a future patch, the goal is to change the FDC's default drive type > from auto (falling back to 1.44MB) to auto (falling back to 2.88MB). >=20 > In order to allow users to obtain the old behaviors, though, a mechanis= m > for specifying the exact type of drive we want is needed. >=20 > This patch adds the properties, but it is not acted on yet in favor of > making those changes a little more explicitly clear in standalone patch= es > later in this patch set. >=20 > Signed-off-by: John Snow > --- > @@ -566,6 +569,7 @@ struct FDCtrl { > /* Timers state */ > uint8_t timer0; > uint8_t timer1; > + > }; > =20 Spurious blank line? Otherwise, looks good; Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --MujV8P3aPL3BQB4XfS04fFmkJpPPlqG3K Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWce2xAAoJEKeha0olJ0Nq06cH/31jle2hsYBVA1LTz6QmeBJX pr8LQ2o8aVShlOeXf1CXrx+ZoRyfgMl4A+ORZ8dwvaNAyyT1XuWUla2AOec9YhZU BsON9PX/vt7lcBaeIWmi/PqC/pFdYOTHIlKbpx/nkAL1lKZSSv8zbuxbOh7nMddA jn8U3++jldVFRPVoCRofFHJNXYm5fvswB+cuEIWzczVQLRBFS5sWwJZXhl7Wtbbw 0NvlW+WOG6omin4rIF/Qbk0WdxglZ+/3UzSWaWlJx0wyl1iKFqq9UVi84TCn/Bkh fys2ZzKr7TxDLH93TPV+pUtgNYWq5KpcsIs2JrrK8pFy5ejrjNz6dSgd8Q8DOno= =a29J -----END PGP SIGNATURE----- --MujV8P3aPL3BQB4XfS04fFmkJpPPlqG3K--