From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] coverity: Model g_poll()
Date: Thu, 17 Dec 2015 09:38:03 +0100 [thread overview]
Message-ID: <5672746B.7050005@redhat.com> (raw)
In-Reply-To: <1450336833-27710-1-git-send-email-armbru@redhat.com>
On 17/12/2015 08:20, Markus Armbruster wrote:
> In my testing, Coverity reported two more CHECKED_RETURN:
>
> * qemu-char.c:1248: fixed in commit c1f2448: "qemu-char: retry g_poll
> on EINTR".
>
> * migration/qemu-file-unix.c:75: harmless, cleaned up in commit
> 4e39f57 "migration: Clean up use of g_poll() in
> socket_writev_buffer()
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> v2: Commit message body rewritten, because fixes have been committed
> meanwhile.
Applied, thanks!
Paolo
> scripts/coverity-model.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/scripts/coverity-model.c b/scripts/coverity-model.c
> index e1d5f45..ee5bf9d 100644
> --- a/scripts/coverity-model.c
> +++ b/scripts/coverity-model.c
> @@ -342,6 +342,15 @@ char *g_strconcat(const char *s, ...)
>
> /* Other glib functions */
>
> +typedef struct pollfd GPollFD;
> +
> +int poll();
> +
> +int g_poll (GPollFD *fds, unsigned nfds, int timeout)
> +{
> + return poll(fds, nfds, timeout);
> +}
> +
> typedef struct _GIOChannel GIOChannel;
> GIOChannel *g_io_channel_unix_new(int fd)
> {
>
next prev parent reply other threads:[~2015-12-17 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 7:20 [Qemu-devel] [PATCH v2] coverity: Model g_poll() Markus Armbruster
2015-12-17 8:38 ` Paolo Bonzini [this message]
2015-12-17 9:21 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5672746B.7050005@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).