From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35174)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1a9U4f-0007xp-1l
	for qemu-devel@nongnu.org; Thu, 17 Dec 2015 03:38:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1a9U4b-0002Nh-Lw
	for qemu-devel@nongnu.org; Thu, 17 Dec 2015 03:38:08 -0500
Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]:34090)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1a9U4b-0002Nb-Ge
	for qemu-devel@nongnu.org; Thu, 17 Dec 2015 03:38:05 -0500
Received: by mail-wm0-x22f.google.com with SMTP id l126so12684705wml.1
	for <qemu-devel@nongnu.org>; Thu, 17 Dec 2015 00:38:05 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1450336833-27710-1-git-send-email-armbru@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <5672746B.7050005@redhat.com>
Date: Thu, 17 Dec 2015 09:38:03 +0100
MIME-Version: 1.0
In-Reply-To: <1450336833-27710-1-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] coverity: Model g_poll()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

On 17/12/2015 08:20, Markus Armbruster wrote:
> In my testing, Coverity reported two more CHECKED_RETURN:
> 
> * qemu-char.c:1248: fixed in commit c1f2448: "qemu-char: retry g_poll
>   on EINTR".
> 
> * migration/qemu-file-unix.c:75: harmless, cleaned up in commit
>   4e39f57 "migration: Clean up use of g_poll() in
>   socket_writev_buffer()
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> v2: Commit message body rewritten, because fixes have been committed
> meanwhile.

Applied, thanks!

Paolo

>  scripts/coverity-model.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/scripts/coverity-model.c b/scripts/coverity-model.c
> index e1d5f45..ee5bf9d 100644
> --- a/scripts/coverity-model.c
> +++ b/scripts/coverity-model.c
> @@ -342,6 +342,15 @@ char *g_strconcat(const char *s, ...)
>  
>  /* Other glib functions */
>  
> +typedef struct pollfd GPollFD;
> +
> +int poll();
> +
> +int g_poll (GPollFD *fds, unsigned nfds, int timeout)
> +{
> +    return poll(fds, nfds, timeout);
> +}
> +
>  typedef struct _GIOChannel GIOChannel;
>  GIOChannel *g_io_channel_unix_new(int fd)
>  {
>