From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9WU9-0001OW-1r for qemu-devel@nongnu.org; Thu, 17 Dec 2015 06:12:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9WU4-0001V5-Bo for qemu-devel@nongnu.org; Thu, 17 Dec 2015 06:12:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9WU4-0001Uv-18 for qemu-devel@nongnu.org; Thu, 17 Dec 2015 06:12:32 -0500 References: <0209faa3788f57deeb3ce4a197019b095bc2c05f.1450300479.git.alistair.francis@xilinx.com> <5671F2A1.6060005@redhat.com> <56728E36.7010807@redhat.com> From: Paolo Bonzini Message-ID: <5672989C.7020404@redhat.com> Date: Thu, 17 Dec 2015 12:12:28 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Peter Crosthwaite , QEMU Developers , Alistair Francis On 17/12/2015 12:11, Peter Maydell wrote: > > It's a hack and I don't want it to become a sanctioned way to do it. > > It's already messing around pretty heavily with qdev internals, see the > > line right after QLIST_INSERT_HEAD: > > > > QLIST_INSERT_HEAD(&dev->child_bus, spi_bus, sibling); > > Well, that doesn't look good either. I think my point still > stands -- we should be providing proper infrastructure at > the qdev level to allow SoC container devices to do the > things they need to do, not just letting the containers > mess with the qdev internals. I agree completely. Paolo