From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9Y03-00019M-UZ for qemu-devel@nongnu.org; Thu, 17 Dec 2015 07:49:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9Y00-0004Wq-PO for qemu-devel@nongnu.org; Thu, 17 Dec 2015 07:49:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58635) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9Y00-0004WO-KI for qemu-devel@nongnu.org; Thu, 17 Dec 2015 07:49:36 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 2E42EA3D2A for ; Thu, 17 Dec 2015 12:49:36 +0000 (UTC) References: <1450353308-2082-1-git-send-email-berrange@redhat.com> <5672A3E9.4020900@redhat.com> <20151217120248.GF16238@redhat.com> From: Paolo Bonzini Message-ID: <5672AF5C.9080803@redhat.com> Date: Thu, 17 Dec 2015 13:49:32 +0100 MIME-Version: 1.0 In-Reply-To: <20151217120248.GF16238@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC] qemu-char: add logfile facility to socket backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org On 17/12/2015 13:02, Daniel P. Berrange wrote: >>> > > >>> > > $QEMU -chardev socket,host=localhost,port=9000,\ >>> > > server=on,nowait,id-charserial0,\ >>> > > logfile=/var/log/libvirt/qemu/test-serial0.log >>> > > -device isa-serial,chardev=charserial0,id=serial0 >> > >> > Why for socket only? It would be very useful for stdio and especially vc. > This is just an "RFC" so didn't want to spend the time to wire > up all of them until I got positive feedback on the idea :-) Yes, I think it's fine. I guess one could do weird things with it such as connecting it to a named pipe, but we shouldn't waste time preventing it. > If its acceptable, then I think it could make sense to just > support optional "logfile" on every single backend, except "file" Yeah, I'd even wire it in qemu_chr_fe_write, and only prevent it for "file" at option parsing time. Or just allow it for all of them. Paolo