qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Shannon Zhao <zhaoshenglong@huawei.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Wei Huang <wei@redhat.com>, G Gregory <graeme.gregory@linaro.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	"Huangpeng (Peter)" <peter.huangpeng@huawei.com>,
	qemu-arm <qemu-arm@nongnu.org>,
	Shannon Zhao <shannon.zhao@linaro.org>,
	Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 10/10] ARM: Virt: Add gpio-keys node for Poweroff using DT
Date: Thu, 17 Dec 2015 21:43:33 +0800	[thread overview]
Message-ID: <5672BC05.3080402@huawei.com> (raw)
In-Reply-To: <CAFEAcA8mxByuG1tTWKpcUUXKCh7yAH=AbB2WvgeyC2=9+0GJpQ@mail.gmail.com>



On 2015/12/17 21:39, Peter Maydell wrote:
> On 11 December 2015 at 03:21, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
>> > From: Shannon Zhao <shannon.zhao@linaro.org>
>> >
>> > Add a gpio-keys node. This is used for Poweroff for the systems which
>> > use DT not ACPI.
>> >
>> > Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
>> > Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>> > Tested-by: Wei Huang <wei@redhat.com>
>> > ---
>> >  hw/arm/virt.c | 16 ++++++++++++++++
>> >  1 file changed, 16 insertions(+)
>> >
>> > diff --git a/hw/arm/virt.c b/hw/arm/virt.c
>> > index cb1d45b..bd6781bd 100644
>> > --- a/hw/arm/virt.c
>> > +++ b/hw/arm/virt.c
>> > @@ -52,6 +52,7 @@
>> >  #include "kvm_arm.h"
>> >  #include "hw/smbios/smbios.h"
>> >  #include "qapi/visitor.h"
>> > +#include <linux/input.h>
> You can't include <linux/> headers -- this will cause the build to
> fail on non-Linux hosts. You need "standard-headers/linux/input.h"
> (which is what I suggested you use initially).
> 
Oh, sorry for this.

> I'll fix this up in my tree.
Thanks!

-- 
Shannon

  reply	other threads:[~2015-12-17 13:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11  3:21 [Qemu-devel] [PATCH v5 00/10] Add system_powerdown support on ARM for ACPI and DT Shannon Zhao
2015-12-11  3:21 ` [Qemu-devel] [PATCH v5 01/10] acpi: support serialized method Shannon Zhao
2015-12-15 16:54   ` Peter Maydell
2015-12-15 16:58     ` Shannon Zhao
2015-12-11  3:21 ` [Qemu-devel] [PATCH v5 02/10] acpi: extend aml_interrupt() to support multiple irqs Shannon Zhao
2015-12-15 16:55   ` Peter Maydell
2015-12-15 16:59     ` Shannon Zhao
2015-12-11  3:21 ` [Qemu-devel] [PATCH v5 03/10] ARM: Virt: Add a GPIO controller Shannon Zhao
2015-12-11  3:21 ` [Qemu-devel] [PATCH v5 04/10] ARM: ACPI: Add GPIO controller in ACPI DSDT table Shannon Zhao
2015-12-16 15:48   ` Igor Mammedov
2015-12-11  3:21 ` [Qemu-devel] [PATCH v5 05/10] ARM: ACPI: Add power button device " Shannon Zhao
2015-12-11  3:21 ` [Qemu-devel] [PATCH v5 06/10] ACPI: Add GPIO Connection Descriptor Shannon Zhao
2015-12-11  3:21 ` [Qemu-devel] [PATCH v5 07/10] ACPI: Add aml_gpio_int() wrapper for GPIO Interrupt Connection Shannon Zhao
2015-12-11  3:21 ` [Qemu-devel] [PATCH v5 08/10] ARM: ACPI: Add _E03 for Power Button Shannon Zhao
2015-12-16 15:51   ` Igor Mammedov
2015-12-16 16:07     ` Peter Maydell
2015-12-11  3:21 ` [Qemu-devel] [PATCH v5 09/10] ARM: Virt: Add QEMU powerdown notifier and hook it to GPIO Pin 3 Shannon Zhao
2015-12-11  3:21 ` [Qemu-devel] [PATCH v5 10/10] ARM: Virt: Add gpio-keys node for Poweroff using DT Shannon Zhao
2015-12-17 13:39   ` Peter Maydell
2015-12-17 13:43     ` Shannon Zhao [this message]
2015-12-15 18:36 ` [Qemu-devel] [PATCH v5 00/10] Add system_powerdown support on ARM for ACPI and DT Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5672BC05.3080402@huawei.com \
    --to=zhaoshenglong@huawei.com \
    --cc=graeme.gregory@linaro.org \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shannon.zhao@linaro.org \
    --cc=wei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).