From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37312)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1a9Yrl-0003eT-41
	for qemu-devel@nongnu.org; Thu, 17 Dec 2015 08:45:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1a9Yrg-0001tG-6B
	for qemu-devel@nongnu.org; Thu, 17 Dec 2015 08:45:09 -0500
Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:33283)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1a9Yrg-0001sq-0z
	for qemu-devel@nongnu.org; Thu, 17 Dec 2015 08:45:04 -0500
Received: by mail-wm0-x22d.google.com with SMTP id p187so23852334wmp.0
	for <qemu-devel@nongnu.org>; Thu, 17 Dec 2015 05:45:03 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1450189710-18264-1-git-send-email-pbonzini@redhat.com>
	<1450189710-18264-2-git-send-email-pbonzini@redhat.com>
	<CAFEAcA9fyDNH_aJSmz0SU+JW=wgmjjxcxDzyChk=RPbr2hHQ5w@mail.gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <5672BC5C.50708@redhat.com>
Date: Thu, 17 Dec 2015 14:45:00 +0100
MIME-Version: 1.0
In-Reply-To: <CAFEAcA9fyDNH_aJSmz0SU+JW=wgmjjxcxDzyChk=RPbr2hHQ5w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/6] arm: use "struct ARMCPU" in header
	files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>



On 15/12/2015 17:05, Peter Maydell wrote:
>> >
>> >  typedef struct {
>> > -    ARMCPU *cpu;
>> > +    struct ARMCPU *cpu;
> 
> Couldn't we just put the typedef in typedefs.h instead ?

Even better: we can put the typedef in cpu-qom.h and move the struct
definition to cpu.h.

Paolo