Re: [Qemu-devel] [PATCH v2 08/13] sysbus: Don't use hw_error() in machine_init_done_notifiers

[Thomas Huth <thuth@redhat.com>]

On 17/12/15 13:19, Markus Armbruster wrote:
> platform_bus_map_irq() and platform_bus_map_mmio() use hw_error() to
> fail.  They run in machine_init_done_notifiers, via
> platform_bus_init_notify() and link_sysbus_device().  Printing CPU
> registers is not helpful there.
> 
> Replace hw_error() by error_report(); exit(1).  If these are
> programming errors, it should be replaced by an assertion instead.
> 
> While there, observe that both functions always return 0, and
> link_sysbus_device() ignores the return value.  Change them to void.
> 
> Cc: Alexander Graf <agraf@suse.de>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  hw/core/platform-bus.c | 25 ++++++++++++-------------
>  1 file changed, 12 insertions(+), 13 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>