From: Thomas Huth <thuth@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@pond.sub.org>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
qemu-ppc@nongnu.org, qemu-arm@nongnu.org,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2 01/13] hw: Don't use hw_error() for machine initialization errors
Date: Thu, 17 Dec 2015 15:39:09 +0100 [thread overview]
Message-ID: <5672C90D.5060304@redhat.com> (raw)
In-Reply-To: <1450354795-31608-2-git-send-email-armbru@redhat.com>
On 17/12/15 13:19, Markus Armbruster wrote:
> Printing CPU registers is not helpful during machine initialization.
> Moreover, these are straightforward configuration or "can get
> resources" errors, so dumping core isn't appropriate either. Replace
> hw_error() by error_report(); exit(1). Matches how we report these
> errors in other machine initializations.
>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: qemu-arm@nongnu.org
> Cc: qemu-ppc@nongnu.org
> Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
> Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/alpha/dp264.c | 11 ++++++-----
> hw/arm/highbank.c | 6 ++++--
> hw/char/exynos4210_uart.c | 9 ++++++---
> hw/m68k/an5206.c | 4 +++-
> hw/ppc/mac_newworld.c | 11 ++++++-----
> hw/ppc/mac_oldworld.c | 16 +++++++++-------
> hw/ppc/prep.c | 11 +++++++----
> hw/unicore32/puv3.c | 10 +++++++---
> 8 files changed, 48 insertions(+), 30 deletions(-)
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2015-12-17 14:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 12:19 [Qemu-devel] [PATCH v2 00/13] Clean up some hw_error() misuse Markus Armbruster
2015-12-17 12:19 ` [Qemu-devel] [PATCH v2 01/13] hw: Don't use hw_error() for machine initialization errors Markus Armbruster
2015-12-17 14:39 ` Thomas Huth [this message]
2015-12-17 16:34 ` Richard Henderson
2015-12-17 12:19 ` [Qemu-devel] [PATCH v2 02/13] omap: Don't use hw_error() in device init() methods Markus Armbruster
2015-12-17 14:30 ` Thomas Huth
2015-12-17 14:50 ` Peter Maydell
2015-12-17 15:45 ` Markus Armbruster
2015-12-17 12:19 ` [Qemu-devel] [PATCH v2 03/13] arm_mptimer: Don't use hw_error() in realize() method Markus Armbruster
2015-12-17 12:19 ` [Qemu-devel] [PATCH v2 04/13] etraxfs_eth: Don't use hw_error() in init() method Markus Armbruster
2015-12-17 12:19 ` [Qemu-devel] [PATCH v2 05/13] raven: Mark use of hw_error() in realize() FIXME Markus Armbruster
2015-12-17 12:19 ` [Qemu-devel] [PATCH v2 06/13] error: Don't append a newline when printing the error hint Markus Armbruster
2015-12-17 15:50 ` Eric Blake
2015-12-17 16:19 ` Markus Armbruster
2015-12-17 12:19 ` [Qemu-devel] [PATCH v2 07/13] hw/arm/virt: Fix property "gic-version" error handling Markus Armbruster
2015-12-17 12:19 ` [Qemu-devel] [PATCH v2 08/13] sysbus: Don't use hw_error() in machine_init_done_notifiers Markus Armbruster
2015-12-17 14:33 ` Thomas Huth
2015-12-17 12:19 ` [Qemu-devel] [PATCH v2 09/13] isa: Trivially convert remaining PCI-ISA bridges to realize() Markus Armbruster
2015-12-17 13:37 ` Michael S. Tsirkin
2015-12-17 12:19 ` [Qemu-devel] [PATCH v2 10/13] isa: Clean up error handling around isa_bus_new() Markus Armbruster
2015-12-17 13:41 ` Michael S. Tsirkin
2015-12-17 12:19 ` [Qemu-devel] [PATCH v2 11/13] isa: Clean up inappropriate hw_error() Markus Armbruster
2015-12-17 13:39 ` Michael S. Tsirkin
2015-12-17 14:27 ` Markus Armbruster
2015-12-17 14:37 ` Michael S. Tsirkin
2015-12-17 16:38 ` Richard Henderson
2015-12-17 12:19 ` [Qemu-devel] [PATCH v2 12/13] audio: Clean up inappropriate and unreachable use of hw_error() Markus Armbruster
2015-12-17 12:19 ` [Qemu-devel] [PATCH v2 13/13] xen-hvm: Mark inappropriate error handling FIXME Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5672C90D.5060304@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@pond.sub.org \
--cc=armbru@redhat.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).