From: John Snow <jsnow@redhat.com>
To: Zhu Lingshan <lszhu@suse.com>, qemu-block@nongnu.org
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, pl@kamp.de,
qemu-devel@nongnu.org, ronniesahlberg@gmail.com
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] iscsi: fix readcapacity error message
Date: Thu, 17 Dec 2015 12:06:26 -0500 [thread overview]
Message-ID: <5672EB92.1000605@redhat.com> (raw)
In-Reply-To: <1450240840-563-1-git-send-email-lszhu@suse.com>
On 12/15/2015 11:40 PM, Zhu Lingshan wrote:
> fix:The error message for readcapacity 16 incorrectly mentioned
> a readcapacity 10 failure, fixed the error message.
>
> Signed-off-by: Zhu Lingshan <lszhu@suse.com>
> ---
> block/iscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index bd1f1bf..eb28ddc 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -1270,7 +1270,7 @@ static void iscsi_readcapacity_sync(IscsiLun *iscsilun, Error **errp)
> && retries-- > 0);
>
> if (task == NULL || task->status != SCSI_STATUS_GOOD) {
> - error_setg(errp, "iSCSI: failed to send readcapacity10 command.");
> + error_setg(errp, "iSCSI: failed to send readcapacity10/16 command");
> } else if (!iscsilun->block_size ||
> iscsilun->block_size % BDRV_SECTOR_SIZE) {
> error_setg(errp, "iSCSI: the target returned an invalid "
>
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2015-12-17 17:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 4:40 [Qemu-devel] [PATCH] iscsi: fix readcapacity error message Zhu Lingshan
2015-12-17 17:06 ` John Snow [this message]
2016-01-10 17:48 ` Michael Tokarev
-- strict thread matches above, loose matches on Subject: below --
2015-12-15 3:33 Zhu Lingshan
2015-12-15 20:20 ` [Qemu-devel] [Qemu-block] " John Snow
2015-12-16 4:41 ` Zhu Lingshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5672EB92.1000605@redhat.com \
--to=jsnow@redhat.com \
--cc=lszhu@suse.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).