* Re: [Qemu-devel] [Qemu-block] [PATCH] iscsi: fix readcapacity error message
2015-12-15 3:33 Zhu Lingshan
@ 2015-12-15 20:20 ` John Snow
2015-12-16 4:41 ` Zhu Lingshan
0 siblings, 1 reply; 5+ messages in thread
From: John Snow @ 2015-12-15 20:20 UTC (permalink / raw)
To: Zhu Lingshan, qemu-block
Cc: QEMU Trivial, pbonzini, pl, qemu-devel, ronniesahlberg
CC qemu-trivial, I think this can go in through that tree.
On 12/14/2015 10:33 PM, Zhu Lingshan wrote:
> fix:The error message for readcapacity 16 incorrectly mentioned
> a readcapacity 10 failure, fixed the error message.
>
> Signed-off-by: Zhu Lingshan <lszhu@suse.com>
> ---
> block/iscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index bd1f1bf..eb28ddc 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -1270,7 +1270,7 @@ static void iscsi_readcapacity_sync(IscsiLun *iscsilun, Error **errp)
> && retries-- > 0);
>
> if (task == NULL || task->status != SCSI_STATUS_GOOD) {
> - error_setg(errp, "iSCSI: failed to send readcapacity10 command.");
> + error_setg(errp, "iSCSI: failed to send readcapacity10/16 command");
> } else if (!iscsilun->block_size ||
> iscsilun->block_size % BDRV_SECTOR_SIZE) {
> error_setg(errp, "iSCSI: the target returned an invalid "
>
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [PATCH] iscsi: fix readcapacity error message
@ 2015-12-16 4:40 Zhu Lingshan
2015-12-17 17:06 ` [Qemu-devel] [Qemu-block] " John Snow
2016-01-10 17:48 ` [Qemu-devel] " Michael Tokarev
0 siblings, 2 replies; 5+ messages in thread
From: Zhu Lingshan @ 2015-12-16 4:40 UTC (permalink / raw)
To: qemu-block
Cc: Zhu Lingshan, qemu-trivial, pl, qemu-devel, ronniesahlberg,
pbonzini
fix:The error message for readcapacity 16 incorrectly mentioned
a readcapacity 10 failure, fixed the error message.
Signed-off-by: Zhu Lingshan <lszhu@suse.com>
---
block/iscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index bd1f1bf..eb28ddc 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1270,7 +1270,7 @@ static void iscsi_readcapacity_sync(IscsiLun *iscsilun, Error **errp)
&& retries-- > 0);
if (task == NULL || task->status != SCSI_STATUS_GOOD) {
- error_setg(errp, "iSCSI: failed to send readcapacity10 command.");
+ error_setg(errp, "iSCSI: failed to send readcapacity10/16 command");
} else if (!iscsilun->block_size ||
iscsilun->block_size % BDRV_SECTOR_SIZE) {
error_setg(errp, "iSCSI: the target returned an invalid "
--
2.6.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] iscsi: fix readcapacity error message
2015-12-15 20:20 ` [Qemu-devel] [Qemu-block] " John Snow
@ 2015-12-16 4:41 ` Zhu Lingshan
0 siblings, 0 replies; 5+ messages in thread
From: Zhu Lingshan @ 2015-12-16 4:41 UTC (permalink / raw)
To: John Snow, qemu-block
Cc: QEMU Trivial, pbonzini, pl, qemu-devel, ronniesahlberg
OK, thanks, I have sent the patch again and CC them
On 12/16/2015 04:20 AM, John Snow wrote:
> CC qemu-trivial, I think this can go in through that tree.
>
> On 12/14/2015 10:33 PM, Zhu Lingshan wrote:
>> fix:The error message for readcapacity 16 incorrectly mentioned
>> a readcapacity 10 failure, fixed the error message.
>>
>> Signed-off-by: Zhu Lingshan <lszhu@suse.com>
>> ---
>> block/iscsi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/block/iscsi.c b/block/iscsi.c
>> index bd1f1bf..eb28ddc 100644
>> --- a/block/iscsi.c
>> +++ b/block/iscsi.c
>> @@ -1270,7 +1270,7 @@ static void iscsi_readcapacity_sync(IscsiLun *iscsilun, Error **errp)
>> && retries-- > 0);
>>
>> if (task == NULL || task->status != SCSI_STATUS_GOOD) {
>> - error_setg(errp, "iSCSI: failed to send readcapacity10 command.");
>> + error_setg(errp, "iSCSI: failed to send readcapacity10/16 command");
>> } else if (!iscsilun->block_size ||
>> iscsilun->block_size % BDRV_SECTOR_SIZE) {
>> error_setg(errp, "iSCSI: the target returned an invalid "
>>
> Reviewed-by: John Snow <jsnow@redhat.com>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] iscsi: fix readcapacity error message
2015-12-16 4:40 [Qemu-devel] [PATCH] iscsi: fix readcapacity error message Zhu Lingshan
@ 2015-12-17 17:06 ` John Snow
2016-01-10 17:48 ` [Qemu-devel] " Michael Tokarev
1 sibling, 0 replies; 5+ messages in thread
From: John Snow @ 2015-12-17 17:06 UTC (permalink / raw)
To: Zhu Lingshan, qemu-block
Cc: qemu-trivial, pbonzini, pl, qemu-devel, ronniesahlberg
On 12/15/2015 11:40 PM, Zhu Lingshan wrote:
> fix:The error message for readcapacity 16 incorrectly mentioned
> a readcapacity 10 failure, fixed the error message.
>
> Signed-off-by: Zhu Lingshan <lszhu@suse.com>
> ---
> block/iscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index bd1f1bf..eb28ddc 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -1270,7 +1270,7 @@ static void iscsi_readcapacity_sync(IscsiLun *iscsilun, Error **errp)
> && retries-- > 0);
>
> if (task == NULL || task->status != SCSI_STATUS_GOOD) {
> - error_setg(errp, "iSCSI: failed to send readcapacity10 command.");
> + error_setg(errp, "iSCSI: failed to send readcapacity10/16 command");
> } else if (!iscsilun->block_size ||
> iscsilun->block_size % BDRV_SECTOR_SIZE) {
> error_setg(errp, "iSCSI: the target returned an invalid "
>
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] iscsi: fix readcapacity error message
2015-12-16 4:40 [Qemu-devel] [PATCH] iscsi: fix readcapacity error message Zhu Lingshan
2015-12-17 17:06 ` [Qemu-devel] [Qemu-block] " John Snow
@ 2016-01-10 17:48 ` Michael Tokarev
1 sibling, 0 replies; 5+ messages in thread
From: Michael Tokarev @ 2016-01-10 17:48 UTC (permalink / raw)
To: Zhu Lingshan, qemu-block
Cc: qemu-trivial, pbonzini, pl, qemu-devel, ronniesahlberg
16.12.2015 07:40, Zhu Lingshan wrote:
> fix:The error message for readcapacity 16 incorrectly mentioned
> a readcapacity 10 failure, fixed the error message.
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-10 17:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-16 4:40 [Qemu-devel] [PATCH] iscsi: fix readcapacity error message Zhu Lingshan
2015-12-17 17:06 ` [Qemu-devel] [Qemu-block] " John Snow
2016-01-10 17:48 ` [Qemu-devel] " Michael Tokarev
-- strict thread matches above, loose matches on Subject: below --
2015-12-15 3:33 Zhu Lingshan
2015-12-15 20:20 ` [Qemu-devel] [Qemu-block] " John Snow
2015-12-16 4:41 ` Zhu Lingshan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).